more

[ENG-XXXX](https://stacklet.atlassian.net/browse/ENG-XXXX)

### what

<here>

### why

<here>

### testing

<here>

### docs

<here>

Author: albertodonato

stacklet/client/platform/cli.py

@@ -14,7 +14,6 @@
 from .commands import commands
 from .config import StackletConfig, StackletCredentials
 from .context import StackletContext
-from .formatter import Formatter
 from .utils import default_options, setup_logging
 
 
@@ -104,7 +103,7 @@ def cli(
             "api": api,
         }
 
-    ctx.obj = StackletContext(raw_config=raw_config, config_file=config)
+    ctx.obj = StackletContext(raw_config=raw_config, config_file=config, output_format=output)
 
 
 @cli.command(short_help="Configure stacklet-admin cli")
@@ -295,7 +294,7 @@ def show(ctx):
     """
     Show your config
     """
-    fmt = Formatter.registry.get(ctx.obj["output"])()
+    fmt = ctx.obj.formatter()
     if id_token := StackletCredentials().id_token():
         id_details = jwt.decode(id_token, options={"verify_signature": False})
         click.echo(fmt(id_details))

stacklet/client/platform/commands/cube.py

@@ -11,7 +11,6 @@
 import click
 import requests
 
-from stacklet.client.platform.context import StackletContext
 from stacklet.client.platform.utils import default_options, get_token
 
 
@@ -59,10 +58,9 @@ def resource_counts(ctx):
 
 
 def _run_query(ctx, query):
-    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
     token = get_token()
 
-    url = f"https://{context.config.cubejs}/cubejs-api/v1/load"
+    url = f"https://{ctx.obj.config.cubejs}/cubejs-api/v1/load"
 
     data = {"query": query}
     response = requests.post(
@@ -74,10 +72,9 @@ def _run_query(ctx, query):
 
 
 def _get(ctx, path: str):
-    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
     token = get_token()
 
-    url = f"https://{context.config.cubejs}/cubejs-api/{path}"
+    url = f"https://{ctx.obj.config.cubejs}/cubejs-api/{path}"
 
     response = requests.get(
         url=url,

stacklet/client/platform/commands/user.py

@@ -4,7 +4,6 @@
 import click
 
 from stacklet.client.platform.cognito import CognitoUserManager
-from stacklet.client.platform.context import StackletContext
 from stacklet.client.platform.utils import default_options
 
 
@@ -28,8 +27,7 @@ def add(ctx, username, password, email=None, phone_number=None, permanent=True):
     """
     Add a cognito user in Stacklet
     """
-    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
-    manager = CognitoUserManager.from_context(context)
+    manager = CognitoUserManager.from_context(ctx.obj)
     manager.create_user(
         user=username,
         password=password,
@@ -47,8 +45,7 @@ def ensure_group(ctx, username, group):
     """
     Ensure that the specified user has the group if the group is available.
     """
-    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
-    manager = CognitoUserManager.from_context(context)
+    manager = CognitoUserManager.from_context(ctx.obj)
     success = manager.ensure_group(
         user=username,
         group=group,

stacklet/client/platform/config.py

@@ -20,6 +20,8 @@
 DEFAULT_CONFIG_DIR = Path("~/.stacklet").expanduser()
 DEFAULT_CONFIG_FILE = DEFAULT_CONFIG_DIR / "config.json"
 
+DEFAULT_OUTPUT_FORMAT = "yaml"
+
 
 class StackletConfig:
     schema = {

stacklet/client/platform/context.py

@@ -3,14 +3,21 @@
 
 import os
 
-from .config import DEFAULT_CONFIG_FILE, StackletConfig
+from .config import DEFAULT_CONFIG_FILE, DEFAULT_OUTPUT_FORMAT, StackletConfig
+from .formatter import Formatter
 
 
 class StackletContext:
     """CLI Execution Context."""
 
-    def __init__(self, raw_config: dict | None = None, config_file: str | None = None):
+    def __init__(
+        self,
+        raw_config: dict | None = None,
+        config_file: str | None = None,
+        output_format: str = DEFAULT_OUTPUT_FORMAT,
+    ):
         self.raw_config = raw_config
+        self.formatter = Formatter.registry.get(output_format)
         if raw_config:
             self.config = StackletConfig(**raw_config)
         else:

stacklet/client/platform/executor.py

@@ -6,8 +6,6 @@
 
 import requests
 
-from stacklet.client.platform.context import StackletContext
-from stacklet.client.platform.formatter import Formatter
 from stacklet.client.platform.registry import PluginRegistry
 from stacklet.client.platform.utils import _PAGINATION_OPTIONS, get_token, wrap_command
 
@@ -81,5 +79,5 @@ def _run_graphql(ctx, name=None, variables=None, snippet=None, raw=False):
     res = executor.run(snippet=snippet, variables=variables)
     if raw:
         return res
-    fmt = Formatter.registry.get(ctx.obj["output"])()
+    fmt = ctx.obj.formatter()
     return fmt(res)

stacklet/client/platform/formatter.py

@@ -12,12 +12,6 @@ class Formatter:
     registry = PluginRegistry("formats")
 
 
-@Formatter.registry.register("")
-class NullFormatter(Formatter):
-    def __call__(self, value):
-        raise NotImplementedError("Null Formatter")
-
-
 @Formatter.registry.register("plain")
 class RawFormatter(Formatter):
     def __call__(self, value):

stacklet/client/platform/utils.py

@@ -5,14 +5,14 @@
 
 import click
 
-from .config import DEFAULT_CONFIG_FILE, StackletCredentials
+from .config import DEFAULT_CONFIG_FILE, DEFAULT_OUTPUT_FORMAT, StackletCredentials
 from .formatter import Formatter
 
 _DEFAULT_OPTIONS = {
     "config": {"default": DEFAULT_CONFIG_FILE, "help": "Configuration file"},
     "output": {
         "type": click.Choice(list(Formatter.registry.keys()), case_sensitive=False),
-        "default": "",
+        "default": DEFAULT_OUTPUT_FORMAT,
         "help": "Output type",
     },
     "cognito_user_pool_id": {