WIP

Author: albertodonato

stacklet/client/platform/cli.py

@@ -10,18 +10,27 @@
 import jwt
 import requests
 
-from stacklet.client.platform.cognito import CognitoUserManager
-from stacklet.client.platform.commands import commands
-from stacklet.client.platform.config import StackletConfig
-from stacklet.client.platform.context import StackletContext
-from stacklet.client.platform.formatter import Formatter
-from stacklet.client.platform.utils import click_group_entry, default_options
+from .cognito import CognitoUserManager
+from .commands import commands
+from .config import StackletConfig, StackletCredentials
+from .context import StackletContext
+from .formatter import Formatter
+from .utils import default_options, setup_logging
 
 
 @click.group()
 @default_options()
 @click.pass_context
-def cli(*args, **kwargs):
+def cli(
+    ctx,
+    config,
+    output,
+    cognito_user_pool_id,
+    cognito_client_id,
+    cognito_region,
+    api,
+    v,
+):
     """
     Stacklet CLI
 
@@ -77,7 +86,25 @@ def cli(*args, **kwargs):
             --after $after_token \\
             list
     """
-    click_group_entry(*args, **kwargs)
+    setup_logging(v)
+
+    config_items = [cognito_user_pool_id, cognito_client_id, cognito_region, api]
+    if any(config_items) and not all(config_items):
+        raise Exception(
+            "All options must be set for config items: --cognito-user-pool-id, "
+            + "--cognito-client-id, --cognito-region, and --api"
+        )
+
+    raw_config = None
+    if all(config_items):
+        raw_config = {
+            "cognito_user_pool_id": cognito_user_pool_id,
+            "cognito_client_id": cognito_client_id,
+            "region": cognito_region,
+            "api": api,
+        }
+
+    ctx.obj = StackletContext(raw_config=raw_config, config_file=config)
 
 
 @cli.command(short_help="Configure stacklet-admin cli")
@@ -268,14 +295,12 @@ def show(ctx):
     """
     Show your config
     """
-    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
     fmt = Formatter.registry.get(ctx.obj["output"])()
-    if os.path.exists(os.path.expanduser(StackletContext.DEFAULT_ID)):
-        with open(os.path.expanduser(StackletContext.DEFAULT_ID), "r") as f:
-            id_details = jwt.decode(f.read(), options={"verify_signature": False})
+    if id_token := StackletCredentials().id_token():
+        id_details = jwt.decode(id_token, options={"verify_signature": False})
         click.echo(fmt(id_details))
         click.echo()
-    click.echo(fmt(context.config.to_json()))
+    click.echo(fmt(ctx.obj.config.to_json()))
 
 
 @cli.command(short_help="Login to Stacklet")
@@ -295,18 +320,19 @@ def login(ctx, username, password):
 
     If password is not passed in, your password will be prompted
     """
-    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    config = ctx.obj.config
+    can_sso_login = ctx.obj.can_sso_login()
     # sso login
-    if context.can_sso_login() and not any([username, password]):
+    if can_sso_login and not any([username, password]):
         from stacklet.client.platform.vendored.auth import BrowserAuthenticator
 
         BrowserAuthenticator(
-            authority_url=context.config.auth_url,
-            client_id=context.config.cognito_client_id,
-            idp_id=context.config.idp_id,
+            authority_url=config.auth_url,
+            client_id=config.cognito_client_id,
+            idp_id=config.idp_id,
         )()
         return
-    elif not context.can_sso_login() and not any([username, password]):
+    elif not can_sso_login and not any([username, password]):
         click.echo(
             "To login with SSO ensure that your configuration includes "
             + "auth_url, and cognito_client_id values."
@@ -318,15 +344,12 @@ def login(ctx, username, password):
         username = click.prompt("Username")
     if not password:
         password = click.prompt("Password", hide_input=True)
-    manager = CognitoUserManager.from_context(context)
-    res = manager.login(
+    manager = CognitoUserManager.from_context(ctx.obj)
+    id_token, access_token = manager.login(
         user=username,
         password=password,
     )
-    if not os.path.exists(os.path.dirname(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS))):
-        os.makedirs(os.path.dirname(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS)))
-    with open(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS), "w+") as f:  # noqa
-        f.write(res)
+    StackletCredentials().write(id_token, access_token)
 
 
 for c in commands:

stacklet/client/platform/client.py

@@ -3,29 +3,27 @@
 
 # platform client using cli
 
-from pathlib import Path
 
 import jmespath
 
 # import the commands so the registry is populated when the client is instantiated
-import stacklet.client.platform.commands  # noqa
-from stacklet.client.platform.context import StackletContext
-from stacklet.client.platform.executor import StackletGraphqlExecutor
-from stacklet.client.platform.utils import _PAGINATION_OPTIONS, get_token
+from . import commands  # noqa
+from .config import DEFAULT_CONFIG_FILE, StackletCredentials
+from .context import StackletContext
+from .executor import StackletGraphqlExecutor
+from .utils import _PAGINATION_OPTIONS
 
 
 def platform_client(pager=False, expr=False):
     # for more pythonic experience, pass expr=True to de-graphqlize the result
     # for automatic pagination handling, pass pager=True
-    if (
-        not Path(StackletContext.DEFAULT_CONFIG).expanduser().exists()
-        or not Path(StackletContext.DEFAULT_CREDENTIALS).expanduser().exists()
-    ):
+    creds = StackletCredentials()
+    token = creds.api_token()
+    if not DEFAULT_CONFIG_FILE.exists() or not token:
         raise ValueError("Please configure and authenticate on stacklet-admin cli")
 
     d = {}
     ctx = StackletContext(raw_config={})
-    token = get_token()
     executor = StackletGraphqlExecutor(ctx, token)
 
     for k, snippet in StackletGraphqlExecutor.registry.items():

stacklet/client/platform/cognito.py

@@ -71,14 +71,15 @@ def create_user(self, user, password, email, phone_number, permanent=True):
         self.log.debug(res)
         return True
 
-    def login(self, user, password):
+    def login(self, user, password) -> tuple[str, str]:
         res = self.client.initiate_auth(
             ClientId=self.user_pool_client_id,
             AuthFlow="USER_PASSWORD_AUTH",
             AuthParameters={"USERNAME": user, "PASSWORD": password},
         )
         self.log.debug("Authentication Success")
-        return res["AuthenticationResult"]["AccessToken"]
+        auth = res["AuthenticationResult"]
+        return auth["IdToken"], auth["AccessToken"]
 
     def ensure_group(self, user, group) -> bool:
         try:

stacklet/client/platform/commands/account.py

@@ -7,7 +7,7 @@
 
 from stacklet.client.platform.executor import StackletGraphqlExecutor, _run_graphql, snippet_options
 from stacklet.client.platform.graphql import StackletGraphqlSnippet
-from stacklet.client.platform.utils import click_group_entry, default_options
+from stacklet.client.platform.utils import default_options
 
 
 @StackletGraphqlExecutor.registry.register("list-accounts")
@@ -287,7 +287,6 @@ def account(*args, **kwargs):
         $ stacklet account --output json list
 
     """
-    click_group_entry(*args, **kwargs)
 
 
 @account.command()

stacklet/client/platform/commands/accountgroup.py

@@ -5,7 +5,7 @@
 
 from stacklet.client.platform.executor import StackletGraphqlExecutor, _run_graphql, snippet_options
 from stacklet.client.platform.graphql import StackletGraphqlSnippet
-from stacklet.client.platform.utils import click_group_entry, default_options
+from stacklet.client.platform.utils import default_options
 
 
 @StackletGraphqlExecutor.registry.register("list-account-groups")
@@ -308,7 +308,9 @@ class RemoveAccountGroupItem(StackletGraphqlSnippet):
 @default_options()
 @click.pass_context
 def account_group(*args, **kwargs):
-    click_group_entry(*args, **kwargs)
+    """
+    Manage account groups
+    """
 
 
 @account_group.command()

stacklet/client/platform/commands/binding.py

@@ -5,7 +5,7 @@
 
 from stacklet.client.platform.executor import StackletGraphqlExecutor, _run_graphql, snippet_options
 from stacklet.client.platform.graphql import StackletGraphqlSnippet
-from stacklet.client.platform.utils import click_group_entry, default_options
+from stacklet.client.platform.utils import default_options
 
 
 @StackletGraphqlExecutor.registry.register("list-bindings")
@@ -265,7 +265,6 @@ def binding(*args, **kwargs):
     """
     Query and run mutations against bindings in Stacklet Platform
     """
-    click_group_entry(*args, **kwargs)
 
 
 @binding.command()

stacklet/client/platform/commands/cube.py

@@ -12,7 +12,7 @@
 import requests
 
 from stacklet.client.platform.context import StackletContext
-from stacklet.client.platform.utils import click_group_entry, default_options, get_token
+from stacklet.client.platform.utils import default_options, get_token
 
 
 @click.group()
@@ -22,7 +22,6 @@ def cubejs(*args, **kwargs):
     """
     Run arbitrary cubejs queries
     """
-    click_group_entry(*args, **kwargs)
 
 
 @cubejs.command()

stacklet/client/platform/commands/graphql.py

@@ -8,7 +8,7 @@
 
 from stacklet.client.platform.executor import _run_graphql
 from stacklet.client.platform.graphql import AdHocSnippet
-from stacklet.client.platform.utils import click_group_entry, default_options
+from stacklet.client.platform.utils import default_options
 
 
 @click.group()
@@ -18,7 +18,6 @@ def graphql(*args, **kwargs):
     """
     Run arbitrary graphql snippets
     """
-    click_group_entry(*args, **kwargs)
 
 
 @graphql.command()

stacklet/client/platform/commands/policy.py

@@ -6,7 +6,7 @@
 from stacklet.client.platform.exceptions import InvalidInputException
 from stacklet.client.platform.executor import StackletGraphqlExecutor, _run_graphql, snippet_options
 from stacklet.client.platform.graphql import StackletGraphqlSnippet
-from stacklet.client.platform.utils import click_group_entry, default_options
+from stacklet.client.platform.utils import default_options
 
 
 @StackletGraphqlExecutor.registry.register("list-policies")
@@ -144,7 +144,9 @@ class ShowPolicy(StackletGraphqlSnippet):
 @default_options()
 @click.pass_context
 def policy(*args, **kwargs):
-    click_group_entry(*args, **kwargs)
+    """
+    Manage policies
+    """
 
 
 @policy.command()

stacklet/client/platform/commands/policycollection.py

@@ -5,7 +5,7 @@
 
 from stacklet.client.platform.executor import StackletGraphqlExecutor, _run_graphql, snippet_options
 from stacklet.client.platform.graphql import StackletGraphqlSnippet
-from stacklet.client.platform.utils import click_group_entry, default_options
+from stacklet.client.platform.utils import default_options
 
 
 @StackletGraphqlExecutor.registry.register("list-policy-collections")
@@ -256,7 +256,9 @@ class RemovePolicyCollection(StackletGraphqlSnippet):
 @default_options()
 @click.pass_context
 def policy_collection(*args, **kwargs):
-    click_group_entry(*args, **kwargs)
+    """
+    Manage policy collections
+    """
 
 
 @policy_collection.command()