Repository navigation
feat(stacklet): brand as AssetDB (Preview) and link the Redash AssetDB (ENG-8329) - #13
Merged
Ahmore merged 7 commits intoAug 13, 2026
Conversation
Superset ships alongside the Redash-backed "AssetDB" rather than replacing it, so the two need distinct names in the app switcher. Rename this deployment to "AssetDB v2", matching the entry the other apps now render for it. Needs the @stacklet/ui release that widens `V2AppName` to accept "AssetDB v2" (stacklet/platform-ui ENG-8329). fixes: ENG-8329
Author
|
@greptile review |
|
| Filename | Overview |
|---|---|
| superset-frontend/src/stacklet/appSelector.ts | Adds Redash-aware application naming, selector entries, and development fallback behavior without an eligible follow-up defect. |
| superset-frontend/src/stacklet/StackletSidebar.tsx | Uses the computed application name and conditionally scopes preview-only styling. |
| superset-frontend/src/stacklet/stackletSidebarOverrides.css | Adds narrowly scoped layout adjustments for the longer preview label. |
| superset-frontend/src/stacklet/appSelector.test.ts | Covers selector contents and branding with Redash present, absent, and under development fallback. |
| superset-frontend/package.json | Updates @stacklet/ui to the release supporting AssetDB (Preview). |
| superset-frontend/package-lock.json | Resolves the design-system dependency update to version 2.16.0. |
Reviews (8): Last reviewed commit: "fix(stacklet): regenerate the lockfile w..." | Re-trigger Greptile
Now that this deployment is branded "AssetDB v2" there is no longer a name clash, and AssetDB v2 was the only app you could not hop back to v1 from. The `redash` key already ships in the bootstrap `stacklet.urls` payload, so gate the entry on it like the other siblings and add it to the local-dev fallbacks. fixes: ENG-8329
Author
|
@greptile review |
Product decision: no "v2" branding. This deployment is "AssetDB (Preview)" while the Redash-backed AssetDB is still deployed alongside it, and takes over the plain "AssetDB" name in environments without Redash — so the constant becomes getSupersetAppName(), keyed on the bootstrap redash URL. fixes: ENG-8329
Ahmore
changed the title
Author
|
@greptile review |
The longer name overflows the app-selector pill past the sidebar edge with the component defaults. Tighten the header row's padding and gap, drop the label to 12px, and center-align the trigger so the tile icon sits level with the smaller text — as Superset-local CSS on top of the scoped stylesheet, keyed on the trigger's aria-label rather than minified utility classes, so the shared @stacklet/ui component stays untouched. fixes: ENG-8329
Author
|
@greptile review |
Shrink the logo to 24px alongside the smaller type, and apply the whole override set only while the Redash-backed AssetDB exists — a `stacklet-preview-branding` class stamped on the scope wrapper gates the CSS, so the plain "AssetDB" branding keeps the component defaults. Both the class and the stylesheet are marked for removal with Redash. fixes: ENG-8329
Author
|
@greptile review |
2.16.0 widens `V2AppName` with "AssetDB (Preview)" (stacklet/platform-ui#3317), which this branch's `selectedApp` needs — `tsc --noEmit` now passes. npm moved the dependency into alphabetical order while resolving it. fixes: ENG-8329
Author
|
@greptile review |
The previous commit's lockfile was written by npm 11, whose dedupe drops nested entries npm 10 still expects, so `npm ci` in the image (npm 10.8.2) refused it — "Missing: @noble/hashes@2.3.0 from lock file" — and the frontend build then failed on a missing cross-env. Regenerated with npm 10 under node 22 per the repo's engines, reducing the diff to the @stacklet/ui bump alone. Verified with `npm ci --dry-run` on npm 10.8.2. fixes: ENG-8329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Brands this deployment AssetDB (Preview) while the Redash-backed AssetDB is
also deployed (its URL present in bootstrap
stacklet.urls), and plainAssetDB without Redash —
getSupersetAppName()replaces the old constant.Also adds an
AssetDBentry pointing at Redash, so all four apps list the same set.Includes Superset-local CSS (
stackletSidebarOverrides.css) so the longerpill fits the sidebar — tighter header padding/gap, 12px label, 24px logo —
gated on a
stacklet-preview-brandingclass stamped only while Redash exists,and marked for removal with it. Plain "AssetDB" keeps the component defaults.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Deployed to Dario's sandbox (this PR's image,
f3f8770ab99d):https://superset.dev.dariusz.sandbox.stacklet.dev
Open the sidebar app selector — the trigger reads AssetDB (Preview), with
AssetDB, Console and IaC in the dropdown.
npx jest src/stacklet→ 16 passed (appSelector covers both names) andnpm run type→ clean on @stacklet/ui 2.16.0.ADDITIONAL INFORMATION