[albertodonato]

ENG-9440

what

Extend the recorded transport to support REST requests, in addition to
GraphQL ones. GraphQL requests are detected by the query field in the
request body, and keep the existing recordings format. REST requests are
recorded with method, path and body, and responses with status code and body.

Also handle requests without a body.

why

Allow writing acceptance tests for resources and data sources based on the
IaC API.

testing

Existing acceptance tests pass in replay mode with unchanged recordings.

docs

n/a

[cubic-dev-ai]

All reported issues were addressed across 1 file

Architecture diagram

sequenceDiagram
    participant Client as HTTP Client
    participant RT as RecordedTransport
    participant Recorder as Recorder/Player
    participant RealAPI as Real API (record mode)
    
    Note over Client,Recorder: Runtime flow for acceptance tests
    
    Client->>RT: RoundTrip(request)
    
    alt Request has body
        RT->>RT: Read request body
    else Request has no body
        RT->>RT: Proceed without body
    end
    
    RT->>RT: newRecordedRequest() classify request
    alt GraphQL request (query field present)
        RT->>RT: Extract query + variables
    else REST request
        RT->>RT: Capture method + path + body
    end
    
    alt Record mode
        RT->>RealAPI: Forward original request
        RealAPI-->>RT: Response with status + body
        RT->>RT: Parse response
        alt GraphQL request
            RT->>RT: Extract data + errors
        else REST request
            RT->>RT: Extract status code + body
        end
        RT->>Recorder: Save recording (request + response)
        Recorder-->>RT: Recording stored
        RT-->>Client: Return real response
    else Replay mode
        RT->>RT: Build request key
        alt GraphQL request
            RT->>RT: Key = query + variables
        else REST request
            RT->>RT: Key = method + path + compact body
        end
        
        RT->>Recorder: getRecording(key)
        alt Recording found
            Recorder-->>RT: Matching recording
            alt REST request
                RT->>RT: Construct response from status + body
            else GraphQL request
                RT->>RT: Verify query + variables match
                RT->>RT: Construct GraphQL response
            end
            RT-->>Client: Return recorded response
        else No recording found
            Recorder-->>RT: Error
            RT-->>Client: Return empty response + error
        end
    end

Loading

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[fwereade]

LGTM, thanks