Repository navigation
Fix critical Dependabot alerts (zip 9, website build deps) and raise MSRV to 1.88 - #65
Merged
Merged
Conversation
- Upgrade zip 0.6.6 to 9.1.3 (deflate via pure-Rust zlib-rs only), fixing the critical zip cloaking advisory and RUSTSEC-2026-0367/0368/0369. This also removes time 0.3.41 (RUSTSEC-2026-0009), pbkdf2 and base64ct. - Move zip extraction into extract_zip, which rejects symlink and path-escaping entries, with unit tests pinning that behaviour. - Update bytes and crossbeam-epoch so cargo audit reports no vulnerabilities. - Raise rust-version to 1.88 (required by zip 9), add an MSRV Check CI job and an MSRV-aware resolver in .cargo/config.toml. - Website: update proxy-addr, websocket-driver and shell-quote within range and resolve tinypool to ^2.1.2. Refs #63 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the six open critical Dependabot alerts.
zip<= 9.0.4 (zip cloaking, arbitrary file overwrite)Cargo.lockproxy-addr< 2.0.8website/yarn.locktinypool< 2.1.2website/yarn.lock^2.1.2(2.2.0)websocket-driver< 0.7.5website/yarn.lockshell-quote<= 1.8.3website/yarn.lockRust (
zip)This picks up the
zippart of #63:zip9 needs Rust 1.88, sorust-versiongoes from 1.75 to 1.88. The crate had not actually built on 1.75 for several releases.zipis built withdefault-features = false, keeping only the pure-Rust deflate backend (deflate-flate2-zlib-rs), so the release targets need no C toolchain. This also dropstime0.3.41 (RUSTSEC-2026-0009),pbkdf2andbase64ctfrom the lockfile.extract_zip. It now fails on symlink entries or entries whose path would leave the destination, where the old code silently skipped unsafe paths. It still writes plain files only, never applying archive permission bits. Three unit tests pin this: a normal archive, a../traversal and a symlink.bytesandcrossbeam-epochare bumped too, socargo auditreports no vulnerabilities (only the existing unmaintained/unsound warnings remain).MSRV CheckCI job (cargo check --locked --all-targetson 1.88), and.cargo/config.tomlwithincompatible-rust-versions = "fallback"..cargo/**is added to the CI path filters.AGENTS.mdandCHANGELOG.mdare updated.Website
Docusaurus 3.9.2 (and 3.10.2) declares
tinypool ^1.0.2, and the fix only exists in 2.x, hence the resolution. Docusaurus uses the worker pool only whenfuture.experimental_faster.ssgWorkerThreadsis enabled, which this site doesn't do, and tinypool 2.2.0 keeps every option Docusaurus passes to it. The other three were re-resolved within their existing semver ranges.Verification
cargo fmt -- --check,cargo clippy --all-targets -- -D warnings,cargo test --lib(106 passed) andcargo test --test '*'all pass;cargo doc --no-depssucceeds.cargo +1.88 check --locked --all-targetspasses.cargo audit: 0 vulnerabilities.stackql-deploy upgradedownloadedstackql_windows_amd64.zip, extracted it with zip 9, and the resultingstackql.exe --versionreports v0.12.824. The runtime smoke test on push tomaincovers extraction on all six targets.yarn buildof the website succeeds.Closes #63. It covers the advisories, the MSRV declaration, the MSRV CI job, the resolver config and the extraction tests.