Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
check-latest: true
cache: true
id: go
Expand Down Expand Up @@ -333,7 +333,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
check-latest: true
cache: true
id: go
Expand Down Expand Up @@ -596,7 +596,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
check-latest: true
cache: true
id: go
Expand Down Expand Up @@ -991,7 +991,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
check-latest: true
cache: true
id: go
Expand Down Expand Up @@ -1418,7 +1418,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
check-latest: true
cache: true
id: go
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:


env:
GOLANGCI_LINT_VERSION: ${{ vars.GOLANGCI_LINT_VERSION == '' && 'v2.5.0' || vars.GOLANGCI_LINT_VERSION }}
GOLANGCI_LINT_VERSION: ${{ vars.GOLANGCI_LINT_VERSION == '' && 'v2.15.0' || vars.GOLANGCI_LINT_VERSION }}
DEFAULT_STEP_TIMEOUT: ${{ vars.DEFAULT_STEP_TIMEOUT_MIN == '' && '20' || vars.DEFAULT_STEP_TIMEOUT_MIN }}

jobs:
Expand All @@ -25,7 +25,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
cache: false

- name: Check workflow files
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mcp-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- uses: actions/setup-go@v7.0.0
if: runner.os == 'Windows'
with:
go-version: '1.25.3'
go-version: '1.26.10'
- run: npm ci --prefix npm
- run: python scripts/test-packaging.py

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mcp-wringer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v7.0.0
with:
go-version: '1.25.3'
go-version: '1.26.10'
check-latest: true
cache: true

Expand Down
3 changes: 1 addition & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ linters:
- predeclared
- promlinter
- reassign
- revive
- rowserrcheck
- sqlclosecheck
# - staticcheck
Expand All @@ -70,7 +69,7 @@ linters:
exhaustive:
check:
- switch
- map
- mapliteral
exhaustruct:
exclude:
- ^net/http.Client$
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ These guidelines help contributors, human and otherwise, understand and work eff

We also encourage reading [`docs/developer_guide.md`](/docs/developer_guide.md) for further useful information. For deeper understanding of the "brains" of `stackql`, it is worthwhile to consult [the `AGENTS.md` file of `any-sdk`](https://github.com/stackql/any-sdk/blob/main/AGENTS.md) and linked documents from there.

We have upgraded to golang `>= 1.25.3` in order to take advantage of [time simulation and other capabilities in `testing/synctest`](https://go.dev/blog/testing-time).
We have upgraded to golang `>= 1.26.10` in order to take advantage of [time simulation and other capabilities in `testing/synctest`](https://go.dev/blog/testing-time).


## Project Structure & Module Organization
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.25.3-bookworm AS sourceprep
FROM golang:1.26.10-bookworm AS sourceprep

ENV SRC_DIR=/work/stackql/src

Expand Down
4 changes: 2 additions & 2 deletions docs/developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Having installed all dependencies, the `robot` tests should be run from the repo

Running linting locally is also a nice-to-have, and can be done:

- Install `golangci-lint` `v1.59.1` (the current version used in CI) per [the `golangci-lint` doco](https://golangci-lint.run/welcome/install/).
- Install `golangci-lint` `v2.15.0` (the current version used in CI) per [the `golangci-lint` doco](https://golangci-lint.run/welcome/install/).
- From the root directory of the repository: `golangci-lint run`.


Expand Down Expand Up @@ -69,7 +69,7 @@ env CGO_ENABLED=0 PLANCACHEENABLED=false go build \

At this time, we are not dogmatic about how to implement unit tests. Aspirationally, unit tests can be implemented in similar fashion to the none-too opinionated [official testing package documentation](https://pkg.go.dev/testing), and in particular [the overview section](https://pkg.go.dev/testing#pkg-overview).

We have upgraded to golang `>= 1.25.3` in order to take advantage of [time simultion and other capabilites in `testing/synctest`](https://go.dev/blog/testing-time).
We have upgraded to golang `>= 1.26.10` in order to take advantage of [time simultion and other capabilites in `testing/synctest`](https://go.dev/blog/testing-time).

To run all unit tests:

Expand Down
6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/stackql/stackql

go 1.25.3
go 1.26.10

require (
github.com/DATA-DOG/go-sqlmock v1.5.1
Expand All @@ -20,8 +20,8 @@ require (
github.com/spf13/cobra v1.10.2
github.com/spf13/pflag v1.0.10
github.com/spf13/viper v1.10.1
github.com/stackql-labs/omnisdk v0.1.5-beta02
github.com/stackql/any-sdk v0.6.1-alpha03
github.com/stackql-labs/omnisdk v0.1.5-beta04
github.com/stackql/any-sdk v0.6.1-alpha05
github.com/stackql/go-suffix-map v0.0.1-alpha01
github.com/stackql/psql-wire v0.1.3-beta01
github.com/stackql/stackql-parser v0.0.16-alpha02
Expand Down
8 changes: 4 additions & 4 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,10 @@ github.com/spf13/viper v1.10.1 h1:nuJZuYpG7gTj/XqiUwg8bA0cp1+M2mC3J4g5luUYBKk=
github.com/spf13/viper v1.10.1/go.mod h1:IGlFPqhNAPKRxohIzWpI5QEy4kuI7tcl5WvR+8qy1rU=
github.com/spiffe/go-spiffe/v2 v2.7.0 h1:uXe1MflJoHw58wAUvxVlcM7WpKtijWG7I1UidcGh6g4=
github.com/spiffe/go-spiffe/v2 v2.7.0/go.mod h1:47Q0Q9/AqGha8QLHp+kxpH4Wca7X7EnOtlIJy3mxZ3U=
github.com/stackql-labs/omnisdk v0.1.5-beta02 h1:39dDzNj+zpgVl3RAZb1FADzlffJQTeiPbi6/aUMQmck=
github.com/stackql-labs/omnisdk v0.1.5-beta02/go.mod h1:2P2vFi+c/wEeQ3kFgIt0QuIlefpuzIoTm6bPJAiLAvQ=
github.com/stackql/any-sdk v0.6.1-alpha03 h1:8WPgE+MftTnLNsR/WbDkyujnuyaQbM1PvQTgEsuNbR4=
github.com/stackql/any-sdk v0.6.1-alpha03/go.mod h1:ahkRgwHHEn7RTmSfKrshPVk6i4X1BdHknSeBflSyRac=
github.com/stackql-labs/omnisdk v0.1.5-beta04 h1:oICaMprn4rIewH/tuEVJ4pPToTYpF0kfKEV38BnV460=
github.com/stackql-labs/omnisdk v0.1.5-beta04/go.mod h1:G3ny8qDG0WyH5NHeUdpDg1snkHIUtd+puOnW5B21FRs=
github.com/stackql/any-sdk v0.6.1-alpha05 h1:rAjZ/FibcM/FCs9yDtdaNky5Hh/obeYjD0vTrruRipU=
github.com/stackql/any-sdk v0.6.1-alpha05/go.mod h1:8/Es9uuqbR+mb2mbmVLSmXJrG7kcHIRZLbduuxkDpfs=
github.com/stackql/go-suffix-map v0.0.1-alpha01 h1:TDUDS8bySu41Oo9p0eniUeCm43mnRM6zFEd6j6VUaz8=
github.com/stackql/go-suffix-map v0.0.1-alpha01/go.mod h1:QAi+SKukOyf4dBtWy8UMy+hsXXV+yyEE4vmBkji2V7g=
github.com/stackql/psql-wire v0.1.3-beta01 h1:xDpR3e09xt74GBSkxYKIhfTMPnKY/Utgu2rl1ctEuF8=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func (np *naiveNativeResultSetPreparator) nativeProtect(
table := sqldata.NewSQLTable(0, "meta_table")
rCols := make([]sqldata.ISQLColumn, len(columns))
for f := range rCols {
//nolint:gosec // Both slices are allocated from len(columns).
rCols[f] = np.typCfg.GetPlaceholderColumn(table, columns[f], np.typCfg.GetDefaultOID())
}
rv.SetSQLResultFn(func() sqldata.ISQLResultStream {
Expand Down
2 changes: 1 addition & 1 deletion internal/stackql/drm/drm_cfg.go
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ func (dc *staticDRMConfig) GenerateDDL(
return dc.sqlSystem.GenerateDDL(relationalTable, dropTable)
}

//nolint:gocritic,govet,funlen,nestif // defer fix
//nolint:gocritic,govet,funlen,nestif,gocognit // defer fix; this orchestration remains intentionally cohesive
func (dc *staticDRMConfig) GenerateInsertDML(
tabAnnotated util.AnnotatedTabulation,
prov formulation.Provider,
Expand Down
1 change: 1 addition & 0 deletions internal/stackql/planbuilder/plan_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ func (pgb *standardPlanGraphBuilder) arrangePrebuildIndirects(
return selectPrimitiveNode, nil
}

//nolint:gocognit // DDL dispatch stays together to preserve the existing control flow.
func (pgb *standardPlanGraphBuilder) handleDDL(pbi planbuilderinput.PlanBuilderInput) error {
handlerCtx := pbi.GetHandlerCtx()
node, ok := pbi.GetDDL()
Expand Down
2 changes: 1 addition & 1 deletion internal/test/testhttpapi/httptestutils.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func NewHTTPRequestExpectations(body io.ReadCloser, header http.Header, method s
}

func DefaultHandler(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "hello %s\n", path.Base(r.URL.Path))
fmt.Fprintf(w, "hello %s\n", path.Base(r.URL.Path)) //nolint:gosec // Test response is plain text, not HTML.
}

func getBodyMap(bodyBytes []byte, contentTypeHeader []string) (map[string]interface{}, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/mcp_server/render/render.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func unwrap(v any) any {
return nil
}
rv := reflect.ValueOf(v)
if rv.Kind() == reflect.Ptr {
if rv.Kind() == reflect.Ptr { //nolint:govet // Keep the explicit kind check for readability.
if rv.IsNil() {
return nil
}
Expand Down
1 change: 1 addition & 0 deletions pkg/prettyprint/prettyprint.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func (pp *PrettyPrinter) PrintPlaceholderJSON(body interface{}) (string, error)
}
}

//nolint:gocognit // Recursive formatting keeps JSON type handling in one place.
func (pp *PrettyPrinter) printTemplatedJSON(body interface{}) (string, error) {
startPos := pp.getCurrentIndentation()
switch bt := body.(type) {
Expand Down
Loading