feat(appsync): AWS AppSync GraphQL APIs + data sources + api keys - #1230
Merged
Conversation
Control-plane surface (restJson1 verb+path under /v1/): GraphQL APIs with stable apiId, two-key uris, and arn; data sources with dataSourceArn; API keys with clock-computed hour-floored expiry and validity-bounds enforcement; plus resource tagging. Wired into the AWS provider and wire server, registered before the MSK handler so /v1/tags for AppSync ARNs is not shadowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the AWS AppSync control plane (Track 1, control-plane only — no GraphQL execution). AppSync speaks awsRestjson1 with verb+path routing under the
/v1/prefix (no X-Amz-Target), modeled on the existing OpenSearch/API Gateway restJson1 handlers.Surface (17 operations)
/v1/tags/{resourceArn})Correct cloud semantics
apiIdgenerated once at create and never regenerated — arn and the two-keyurismap (GRAPHQL + REALTIME) derive from it, so repeated GETs never drift.dataSourceArncomputed once, immutable across updates.expirescomputed once via the configured clock, floored to the hour, with 1..365-day validity bounds enforced (ApiKeyValidityOutOfBoundsException); never recomputed on List/Get.xrayEnabledexplicit-false round-trips;visibilitydefaults GLOBAL,apiTypedefaults GRAPHQL.X-Amzn-Errortypeerror envelope with the precise exception names.Architecture
services/appsync/driver, providerproviders/aws/appsync(memstore + Snapshottable), wireserver/aws/appsync— no cloud-prefixed dirs./v1/tagsfor AppSync ARNs is claimed (MSK claims/v1/tagsunconditionally); disjoint from Batch.Verification
go build/vet,gofmt,golangci-lint(0 issues),-racetests (provider 88.9%, SDK round-trip through the wire server), persist completeness + wiring parity all green.serveon a temp port with the realhashicorp/awsTerraform provider (aws_appsync_graphql_api+aws_appsync_datasource+aws_appsync_api_key): apply → no-drift plan → in-place update → destroy, plus aws-cli and aws-sdk-go-v2 round-trips proving apiId stable, uris two-key, dataSourceArn, and api-key expires computed-once.Deferred (control-plane scope): real GraphQL schema/resolvers/execution, functions, types, resolver caching, introspection, domain names, merged APIs, event APIs.