feat(gcp): Dataplex lakes + zones + assets - #1254
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New greenfield GCP control-plane service: Dataplex (
dataplex.googleapis.com/v1), Track-1 control-plane emulation of thelakes → zones → assetshierarchy. Unmodifiedgoogle.golang.org/api/dataplexclients, gcloud, and the Terraformgoogle_dataplex_lake/google_dataplex_zone/google_dataplex_assetresources hit the handler unchanged.Provider tier: all three resources are GA in the stable
hashicorp/googleprovider (verified live against v5.45.2). The e2e drove them at the provider's default/v1/base path — no/v1beta1/needed.What's covered
done:truewith the resource as a typedAny, exact@typegoogle.cloud.dataplex.v1.{Lake,Zone,Asset}), so a Terraform/SDK LRO wait terminates on the first poll.l1never touchesl10's descendants (guard test + live curl proof).?lakeId=/?zoneId=/?assetId=, body-name fallback), 409 on dup, 404 on missing parent, 400 on bad enums (zonetype,resourceSpec.locationType, assetresourceSpec.type).updateMasktop-level replace; unmasked fields survive.name, deterministicuid,state=ACTIVE, lakeserviceAccount,assetStatus/metastoreStatus/resourceStatus/securityStatus/discoveryStatus,createTime/updateTime— all derived from stable stored inputs and byte-identical across reads. Rich spec blocks (discoverySpec/resourceSpec/metastore) round-trip verbatim as raw passthrough.lro.Registrywiring;Matchesyieldsoperationspaths to the shared poller (no sibling operations-404 regression). COW memstore with deep clone on read;Snapshottableauto-discovered by the persist completeness test.Live e2e (Terraform, stable hashicorp/google v5.45.2, default /v1/ path)
applya lake + zone + asset (labels/description/specs) → all created, LRO did not hang, statesACTIVE.plan -detailed-exitcode→ exit 0, no drift (on uid/state/service_account/*_status/create_time + the spec blocks).destroy→ all gone (cascade verified).l1/l10prefix-collision cascade (curl): deletel1→ its children 404,l10's children survive 200.Files
services/dataplex/driver/,providers/gcp/dataplex/,server/gcp/dataplex/; wired intoproviders/gcp/gcp.go,server/gcp/gcp.go(SetOperationRegistry at the shared LRO registry),server/gcp/from_provider.go; regenerateddocs/coverage/(dataplex-only diff).Deferrals (tasks, entities, entryGroups, dataScans, environments, IAM verbs, referenced-resource data plane) are recorded out of scope.