Fix cart line attributes being dropped and userErrors not logged - #372
Merged
ryanmitchell merged 1 commit intoSep 22, 2026
Merged
Conversation
Contributor
|
Good spot, thank you for both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small bugs in the cart JS, both in the same add-to-cart path.
updateFromResponse()builds the line item attributes withattrs[key] = attr.value, butkeyis never defined in that scope. Under a bundler this throws a ReferenceError in strict mode, and otherwise it writes to a global, so line attributes never reach$store['statamic.shopify.cart'].lineItems. This is what you get back fromcartLinesAddwhen you passattributes, so any custom line data (we use it for shirt name and number personalisation) is lost when the cart re-renders.The second one is in
addLines(): theuserErrorsbranch logserrorsfrom the destructured response instead of the user errors it just checked, so the warning is always empty at the point where it would be most useful.Both are in the published JS, so they only reach apps after a re-publish.