Create the storefront client on first use - #373
Merged
ryanmitchell merged 2 commits intoSep 22, 2026
Merged
Conversation
Contributor
|
Great idea, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.jscallscreateStorefrontApiClient()at module load and readswindow.shopifyConfig.urldirectly. On any page that does not output{{ shopify:tokens }}, that throws a TypeError while the module graph is evaluating, which takes down the whole bundle, not just the cart. On a site where the shop is one section of a larger Statamic site, that means the nav, modals and everything else stop working on pages unrelated to the shop.Moving the construction into
request()keeps the same default export and the same call sites (onlyclient.request()is used incart.js), but a page without the tokens tag now simply never constructs a client.