Conversation
The literal "\n\xf5\xdc\n" is invalid UTF-8 and unmarked, so when the package was installed in a UTF-8 locale and then loaded in a C locale (e.g., on stripped-down HPC compute nodes), unserializing the function from the lazy-load DB produced "strings not representable in native encoding" and "cannot be translated to UTF-8" warnings. Since pmatch() assigns all exact matches (sequentially) before attempting any partial ones, discarding the non-exact assignments afterwards gives exactly the result the sentinel was emulating. Fixes #44.
Member
Author
|
Rather dry housekeeping safe to be merged, but I might miss where it is used in the Statnet entire... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The literal "\n\xf5\xdc\n" is invalid UTF-8 and unmarked, so when the package was installed in a UTF-8 locale and then loaded in a C locale (e.g., on stripped-down HPC compute nodes), unserializing the function from the lazy-load DB produced "strings not representable in native encoding" and "cannot be translated to UTF-8" warnings.
Since pmatch() assigns all exact matches (sequentially) before attempting any partial ones, discarding the non-exact assignments afterwards gives exactly the result the sentinel was emulating.
Fixes #44.