Repository navigation
qqnt: fix the baseline typecheck errors on main (no behavior change) - #13
Merged
std-microblock merged 1 commit intoOct 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 是什么
纯基线修复,不含本次回显重复(#12)的任何改动,也没有运行时行为变化。
main(7a1ecfc)的 Unit tests and typecheck 本来就是红的:yarn typecheck(tsc -p tsconfig.test.json)报 4 个类型错,全部在platform-crossgram,由加群邀请按钮那次提交(22f7608)带进来的类型漂移导致。main 的 CI run 39050915894 可以直接看到。因为 #12 需要跑同一个 typecheck job,这个基线红会让任何 PR 的 unit/typecheck 都红,所以单独修在一个 PR 里,和 #12 的功能改动互不掺杂。
4 个错误与修法
packages/platform-crossgram/src/index.ts:1035clickInlineButton实际返回refresh: true,声明的返回类型没有该字段(IMPlatform.clickInlineButton在packages/bridge/src/platform.ts:804要求refresh?: true)refresh?: true,与 bridge 侧接口一致packages/platform-crossgram/src/invite-accept.e2e.test.ts:109{ updates: [] },不符合PlatformEventPublishResultedits)packages/platform-crossgram/src/invite-accept.e2e.test.ts:117messages.getHistory请求缺hashhash: Long.ZEROpackages/platform-crossgram/src/platform.test.ts:255getHistorymock 的返回字面量被拓宽,card.kind不再匹配WireCard联合类型Promise<{ messages: WireMessage[] }>,补WireMessage类型导入验证
yarn typecheck(tsc -p tsconfig.test.json)→ 0 错误(改动前 4 个错误)。vitest run packages/platform-crossgram/src/platform.test.ts packages/platform-crossgram/src/client.test.ts→ 198 passed。与 #12 的关系