Repository navigation
fix: prove checkout success for actions with status conditions - #258
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 28, 2026
jan-kubica
force-pushed
the
fix/checkout-success-conditions-20261028
branch
from
October 28, 2026 08:54
886df9b to
3af6015
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewed local action may need to run after an unrelated check fails, using a status condition such as
!cancelled(). Such a consumer must still prove its selected checkout completed successfully.Accept that path only when every boolean alternative requires the exact selected checkout's
outcome == 'success'. Reuse the existing workflow-trust boolean parser and keep unknown atoms unable to authorize the proof. Unconditional checkout consumers without status overrides retain implicit success semantics.Regression coverage includes conjunctions, disjunctions, nested parentheses, quoted text, another checkout ID and conclusion/outcome distinction. The workflow-trust suite exercises the shared parser extraction.