Skip to content

Add Soroban Common Mistakes to community skills - #86

Open
mariaelisaaraya wants to merge 2 commits into
stellar:mainfrom
mariaelisaaraya:patch-1
Open

Add Soroban Common Mistakes to community skills#86
mariaelisaaraya wants to merge 2 commits into
stellar:mainfrom
mariaelisaaraya:patch-1

Conversation

@mariaelisaaraya

Copy link
Copy Markdown

Adds the soroban-common-mistakes skill to the community skills directory. It reviews Soroban contracts against 22 common security mistake patterns, cross-checked against the official Stellar docs.

Part of a broader open security toolkit for LATAM builders, with the full guide available in both English and Spanish.

@kaankacar following up on your suggestion to submit this here = )

Copilot AI balanced review requested due to automatic review settings August 11, 2026 21:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Soroban Common Mistakes security-review skill to the community directory.

Changes:

  • Adds skill metadata, security topics, languages, and external source link.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

# Conflicts:
#	site/src/data/skills.ts
@kaankacar

Copy link
Copy Markdown
Contributor

Thanks for this, Maria — and for following up here like I'd suggested. This is a nice addition to the catalog: I like that the checklist is Soroban-native rather than a ported EVM list (calling out storage type/TTL and reinitialization instead of reentrancy/tx.origin is exactly the right framing), and the vulnerable/fixed vault pair in examples/ makes the skill easy to try end to end rather than just read about.

One thing before I add it: the card description (and the PR description) say the skill checks "22 recurring security mistakes," but the skill itself consistently says 23 — SKILL.md numbers its checks 1 through 23, examples/vulnerable-vault/src/lib.rs says "Claude will walk through all 23 patterns," and install.sh's post-install banner says "Reviews Soroban contracts against 23 security patterns." Could you update the card description to say 23 so it matches the skill? (Or if 22 was intentional and one item should come out of the list, whichever way you'd rather reconcile it.)

Everything else checked out — the repo's public, the SKILL.md frontmatter is self-contained, the checklist/PR-template/Scout workflow files it references all exist, and the companion-tool links (Scout, OpenZeppelin detectors, Komet, Certora Sunbeam) resolve. Once the count's consistent I'm happy to get this listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants