Skip to content

Don't inspect containers with the dead status #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepchowfun merged 2 commits into from
Sep 1, 2026
Merged

Don't inspect containers with the dead status #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07fadd
Don't inspect containers with the dead status
firecow Aug 31, 2026
c3a75d9
Collect uninspectable container statuses in one array
firecow Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ use sysinfo::{Disk, Disks};
// maximum number of container IDs to query at once.
const CONTAINER_IDS_CHUNK_SIZE: usize = 100;

// The `docker container inspect` command seems to fail on containers with this status. Source:
// The `docker container inspect` command seems to fail on containers with these statuses. Source:
// https://github.com/stepchowfun/docuum/issues/237
const CONTAINER_STATUS_REMOVING: &str = "removing";
const UNINSPECTABLE_CONTAINER_STATUSES: [&str; 2] = ["dead", "removing"];

// These are all the possible statuses returned from `docker container ls`. Source:
// https://docs.docker.com/reference/cli/docker/container/ls/#status
Expand All @@ -39,7 +39,7 @@ const CONTAINER_STATUSES: [&str; 7] = [
"paused",
"restarting",
"running",
CONTAINER_STATUS_REMOVING,
"removing",
];

// A Docker event (a line of output from `docker system events --format '{{json .}}'`)
Expand Down Expand Up @@ -253,7 +253,7 @@ fn image_ids_in_use() -> io::Result<HashSet<String>> {
.chain(
CONTAINER_STATUSES
.iter()
.filter(|&&status| status != CONTAINER_STATUS_REMOVING)
.filter(|&&status| !UNINSPECTABLE_CONTAINER_STATUSES.contains(&status))
.flat_map(|&status| [String::from("--filter"), format!("status={status}")]),
)
.chain(
Expand Down