Conversation
khalford
force-pushed
the
0.4.X
branch
2 times, most recently
from
October 2, 2026 10:28
cf56afd to
8201b71
Compare
qorud02
force-pushed
the
fix-sudoers-line-terminators
branch
from
October 2, 2026 10:41
ea4decc to
e2943a8
Compare
Member
|
Please set the target branch to feature/latest-lts |
Member
|
We just need to build this to confirm it works. Otherwise it looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both sudoers files written by the image builder omit their final line terminator. The
sudo-rsparser used by Ubuntu 26.04 rejects them withmissing line terminator at end of file, as reported in #211.Append a newline to the Ansible
copy.contentvalues for/etc/sudoers.d/cloudand/etc/sudoers.d/cloud-team-user. The sudo rules and file modes stay the same.Fixes #211.
Validation:
block, and checked both generated files end in a newline. This check fails on the original task values and passes after the change; both modes remain0440.visudo-rs 0.2.13from the official Ubuntu 26.04sudo-rs 0.2.13-0ubuntu1.2amd64 package without installing it, then ran it on Ubuntu 24.04 WSL with glibc 2.39 as the unprivilegednobodyuser (UID 65534). Both original files exit 1 withsyntax error: missing line terminator at end of file. Both patched files exit 0 withparsed OKand empty stderr.visudo 1.9.15p5accepts both original and patched files, confirming why the earlier C-parser check did not reproduce the reported error.git diff --checkpasses.The version-specific check above executes the Ubuntu 26.04 packaged parser, not a full Ubuntu 26.04 VM or image build. A full image build was not run.
Prepared with AI assistance; the diff was reviewed and the checks above were executed locally.