Skip to content

#522 Support intel-specific inquiry extension. - #523

Merged
arporter merged 3 commits into
masterfrom
522_inquire_directory
Aug 24, 2026
Merged

#522 Support intel-specific inquiry extension.#523
arporter merged 3 commits into
masterfrom
522_inquire_directory

Conversation

@hiker

@hiker hiker commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Adds the inquire-directory extension, to support Intel's specific arguments to inquire for directories (required for building Jules with Fab).

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (743d453) to head (e69b8db).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          89       89           
  Lines       13886    13891    +5     
=======================================
+ Hits        12810    12815    +5     
  Misses       1076     1076           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker

hiker commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

I have confirmed that with this change Fab can build Jules now. Ready for review.

@hiker

hiker commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

@arporter

Copy link
Copy Markdown
Member

I really think Jules needs to be fixed! However, I have no real concerns about adding it as an extension.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks Joerg.
Will proceed to merge.

@arporter arporter added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Aug 24, 2026
@arporter
arporter merged commit 18ff788 into master Aug 24, 2026
6 checks passed
@arporter
arporter deleted the 522_inquire_directory branch August 24, 2026 15:16
@hiker

hiker commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

I really think Jules needs to be fixed! However, I have no real concerns about adding it as an extension.

FWIW, that was my first idea as well, and I would have happily added a patch to a Jules source file to make Fab work. But it turns out that using inquiry for directories is non-standard. Using standard inquiry for an existing directory works with gnu, but not with intel. There were a suggested work around (test for directory/.), but that didn't work for my test either :( See https://fortran-lang.discourse.group/t/how-to-test-if-a-directory-exists/8731/11 with various solutions (usually involving C code).

I decided to give up, and extend fparser :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ready for merge PR is waiting on final CI checks before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants