#522 Support intel-specific inquiry extension. - #523
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 89 89
Lines 13886 13891 +5
=======================================
+ Hits 12810 12815 +5
Misses 1076 1076 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I have confirmed that with this change Fab can build Jules now. Ready for review. |
|
I really think Jules needs to be fixed! However, I have no real concerns about adding it as an extension. |
arporter
left a comment
There was a problem hiding this comment.
All looks good, thanks Joerg.
Will proceed to merge.
FWIW, that was my first idea as well, and I would have happily added a patch to a Jules source file to make Fab work. But it turns out that using inquiry for directories is non-standard. Using standard inquiry for an existing directory works with gnu, but not with intel. There were a suggested work around (test for I decided to give up, and extend fparser :) |
Adds the inquire-directory extension, to support Intel's specific arguments to
inquirefor directories (required for building Jules with Fab).