ci: pin Windows jobs to supported runner - #24
Merged
Merged
Conversation
stoprocent
force-pushed
the
agent/pin-windows-2022
branch
from
July 27, 2026 09:21
f6b3e6e to
764f7f2
Compare
stoprocent
force-pushed
the
agent/pin-windows-2022
branch
from
July 27, 2026 09:22
764f7f2 to
bcf444d
Compare
stoprocent
marked this pull request as ready for review
July 27, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin Windows build and test jobs to
windows-2022instead of the movingwindows-latestlabel.Why
The current
windows-latestimage exposes Visual Studio 18. Node 20's bundlednode-gyp@10.1.0cannot detect that toolchain, so bothBuild win32-x86and the Node 20 Windows test fail duringnpm ci, before repository code is compiled.Keeping the runner on Windows Server 2022 provides the Visual Studio toolchain supported by the Node 18/20 matrix.
Validation
npm ciwithunknown version ... Visual Studio\\18\\Enterpriseactionlintpasses for the modified workflowsgit diff --checkFixes #23