Repository navigation
fix(docker): EDU_PROFILER_BUILD transmis au build de l'image de dev - #5
Merged
Merged
Conversation
Le README et le .env.example documentent EDU_PROFILER_BUILD (image avec ou sans Excimer), mais compose.yaml ne passait pas l'argument de build EDU_PROFILER au Dockerfile : la variable était sans effet. Bloc build aligné sur celui d'edu-framework. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Le README et le
.env.exampledocumententEDU_PROFILER_BUILD:1(par défaut) donne une image Docker avec le profiler Excimer,0une image sans profiler. Mais lecompose.yamldu skeleton ne passait pas l'argument de buildEDU_PROFILERauDockerfile, donc la variable restait sans effet : l'image avait toujours Excimer.Correction
Le bloc
builddu servicefrankenphptransmet maintenant l'argument, comme dans edu-framework :Le bloc est identique à celui du
compose.yamld'edu-framework (repris dans #4).Tests
Testé en local (Docker 29.9.1, avec un
composer.lockgénéré localement et non commité) :docker compose config:EDU_PROFILER: "1"par défaut,"0"avecEDU_PROFILER_BUILD=0docker compose build frankenphpavecEDU_PROFILER_BUILD=0dans le.env: l'image n'a pas l'extensionexcimerdocker compose build frankenphpsans la variable : l'image a l'extensionexcimerNon testé :
docker compose upavec toute la stack.🤖 Generated with Claude Code