Skip to content

Fix e1002-fix - #141

Merged
bfoujols merged 6 commits into
2.xfrom
main
Oct 5, 2026
Merged

bfoujols merged 6 commits into
2.xfrom
main

Conversation

@bfoujols

@bfoujols bfoujols commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

This pull request contains several small but important improvements to command classes and the request handling in the EduFramework. The changes mainly address method naming consistency, correct usage of class methods, and minor logic and initialization fixes.

Consistency and Correctness in Command Classes

  • Standardized the method name from AddArgument to addArgument in the configure() methods of CreateApiCommand, CreateCliCommand, and CreateControllerCommand for consistency with Symfony's API. [1] [2] [3]
  • Corrected the usage of getNamesCollection from a static call to an instance call in CreateControllerCommand's execute() method, ensuring proper method invocation.

Logic and Initialization Improvements

  • Improved the banner animation in StartCommand by calculating the number of banner lines and erasing only the necessary lines between animation frames, making the output cleaner.
  • Initialized the $hander property to an empty string in the Request class to prevent uninitialized variable issues.

Copilot AI and others added 5 commits October 4, 2026 20:18
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@deepsource-io

deepsource-io Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in 09bba26...14700cb on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Oct 5, 2026 8:32a.m. Review ↗
Shell Oct 5, 2026 8:32a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

codacy-production Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@bfoujols
bfoujols merged commit c4dafb7 into 2.x Oct 5, 2026
3 of 6 checks passed

This branch was successfully deployed

1 active deployment
github-pages — 14700cb7 Deployed Oct 5, 2026 by bfoujols via Deploy to GitHub Pages #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants