Require rubocop explicitly - #143
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
As added, rubocop will be auto-required by Bundler.require(*Rails.groups) in the demo app, so it should be marked require: false (or grouped) to avoid loading a CLI linter at runtime.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR makes RuboCop an explicit Bundler dependency so the repo can invoke it directly (e.g., via Rake/CI) rather than relying on it being pulled in indirectly.
Changes:
- Add
rubocopto the Gemfile dependencies.
File summaries
| File | Description |
|---|---|
| Gemfile | Adds RuboCop as an explicit dependency for linting tasks. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
03919e3 to
9e61787
Compare
Given that we run rubocop directly we should be explicit about the dependency.
9e61787 to
0efcf77
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The RuboCop config enables additional plugins (e.g., rubocop-performance) that are not explicitly declared as Gemfile dependencies, which can lead to brittle linting if transitive dependencies change.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
| gem "rubocop-view_component", require: false | ||
| gem "rubocop", require: false | ||
| gem "standard", require: false |
Given that we run rubocop directly we should be explicit about the dependency.