fix: pass package to importmap:update as named argument

[iliaskhat]

The package name was passed with an integer key, so ArrayInput never filled the "packages" argument. importmap:update then updated every package to its latest version, including major updates.

Summary by Sourcery

Pass selected packages to importmap updates as named arguments to ensure only intended dependencies are updated.

Bug Fixes:

• Restrict importmap updates to the explicitly selected packages, preventing unintended major-version updates across all dependencies.

Enhancements:

• Support array-valued named arguments when constructing console command invocations.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The command now correctly scopes importmap:update to the intended package by passing packages as a named array argument, with command serialization updated to flatten array values into CLI arguments and prevent unintended updates to all packages.

Sequence diagram for scoped importmap package updates

sequenceDiagram
    participant MaintenanceCommand
    participant ConsoleRunner
    participant ImportmapUpdate

    MaintenanceCommand->>ConsoleRunner: runConsoleCommand(command, packages, options)
    ConsoleRunner->>ConsoleRunner: array_push(commandString, ...value)
    ConsoleRunner->>ImportmapUpdate: importmap:update packageName --no-interaction --ansi
    ImportmapUpdate-->>MaintenanceCommand: Update intended package only

Loading

File-Level Changes

Change	Details	Files
Pass the target package to importmap:update using the named packages argument and support array-valued command arguments when constructing the console command.	Replace the positional package value with packages => [$package['name']]. Expand array argument values into individual command-line arguments while preserving existing handling for flags and scalar values.	src/Command/Maintenance/CreatePrForOutdatedDependenciesCommand.php

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If the argument handling is wrong, the maintenance command could fail or generate a PR with an unintended package update. Reverting stops future runs, but any PR already created would need to be closed or corrected.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook