Repository navigation
533 Symfony 6.4 - #452
Merged
Merged
533 Symfony 6.4#452
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Changes recommended
Production service aliases, router resolution, and forwarded-prefix handling contain unresolved regressions.
4 open findings
What changed in this PR
Advances the Symfony 6.4 migration by updating service lookups, request handling, test configuration, and removing CKFinder.
Changes:
- Adds Symfony 6-compatible request parameter handling.
- Migrates legacy service IDs to class-based aliases and enables autowiring.
- Removes the obsolete bundled CKFinder implementation.
| File | Description |
|---|---|
src/Frontend/Modules/Search/Ajax/Autosuggest.php |
Uses compatible integer parsing. |
src/Frontend/Modules/FormBuilder/Widgets/Form.php |
Updates validator lookup. |
src/Frontend/Modules/Blog/Actions/Detail.php |
Updates validator lookup. |
src/Frontend/Files/Core/CKFinder/images/.gitignore |
Removes CKFinder placeholder rules. |
src/Frontend/Files/Core/CKFinder/files/.gitignore |
Removes CKFinder placeholder rules. |
src/Frontend/Files/Core/CKFinder/.gitignore |
Removes CKFinder ignore rules. |
src/Frontend/Core/Engine/TwigTemplate.php |
Updates CSRF service lookup. |
src/Frontend/Core/Engine/Navigation.php |
Changes router service lookup. |
src/Frontend/Core/Engine/Base/Widget.php |
Updates form factory lookup. |
src/Frontend/Core/Engine/Base/Block.php |
Updates form factory lookup. |
src/ForkCMS/Bundle/CoreBundle/Resources/config/services.yml |
Adds service defaults. |
src/Common/WebTestCase.php |
Clears persistent caches during reset. |
src/Common/Core/RequestParameter.php |
Adds compatible request converters. |
src/Common/Core/Model.php |
Updates request-stack lookup. |
src/Backend/Modules/Users/Resources/config/services.yml |
Adds service defaults. |
src/Backend/Modules/Users/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Tags/Ajax/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Tags/Actions/MassAction.php |
Uses array-specific input access. |
src/Backend/Modules/Tags/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Search/Actions/EditSynonym.php |
Uses compatible ID parsing. |
src/Backend/Modules/Profiles/Actions/MassAction.php |
Uses array-specific input access. |
src/Backend/Modules/Profiles/Actions/EditProfileGroup.php |
Uses compatible ID parsing. |
src/Backend/Modules/Profiles/Actions/EditGroup.php |
Uses compatible ID parsing. |
src/Backend/Modules/Profiles/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Profiles/Actions/Block.php |
Uses compatible ID parsing. |
src/Backend/Modules/Profiles/Actions/AddProfileGroup.php |
Uses compatible ID parsing. |
src/Backend/Modules/Pages/Engine/Model.php |
Updates message-bus lookup. |
src/Backend/Modules/Pages/Ajax/Move.php |
Uses compatible integer parsing. |
src/Backend/Modules/Pages/Ajax/GetInfo.php |
Uses compatible ID parsing. |
src/Backend/Modules/Pages/Actions/Index.php |
Uses compatible ID parsing. |
src/Backend/Modules/Pages/Actions/Edit.php |
Updates numeric and boolean parsing. |
src/Backend/Modules/Pages/Actions/Delete.php |
Uses compatible revision parsing. |
src/Backend/Modules/MediaLibrary/Resources/config/storage_providers.yml |
Adds service defaults. |
src/Backend/Modules/MediaLibrary/Resources/config/services.yml |
Adds service defaults. |
src/Backend/Modules/MediaLibrary/Resources/config/managers.yml |
Adds service defaults. |
src/Backend/Modules/MediaLibrary/Resources/config/helpers.yml |
Adds service defaults. |
src/Backend/Modules/MediaLibrary/Resources/config/console.yml |
Adds service defaults. |
src/Backend/Modules/MediaLibrary/Resources/config/cache_builder.yml |
Adds service defaults. |
src/Backend/Modules/MediaLibrary/Installer/Installer.php |
Updates message-bus lookup. |
src/Backend/Modules/MediaLibrary/Component/UploadHandler.php |
Updates chunk parameter parsing. |
src/Backend/Modules/MediaLibrary/Ajax/MediaItemUpload.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Ajax/MediaItemFindAll.php |
Uses compatible folder parsing. |
src/Backend/Modules/MediaLibrary/Ajax/MediaItemEditTitle.php |
Updates message-bus lookup. |
src/Backend/Modules/MediaLibrary/Ajax/MediaItemAddMovie.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Ajax/MediaFolderMove.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Ajax/MediaFolderInfo.php |
Uses compatible ID parsing. |
src/Backend/Modules/MediaLibrary/Ajax/MediaFolderEdit.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Ajax/MediaFolderAdd.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Actions/MediaItemMassAction.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Actions/MediaItemIndex.php |
Uses compatible folder parsing. |
src/Backend/Modules/MediaLibrary/Actions/MediaItemEdit.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Actions/MediaFolderDelete.php |
Updates services and parameters. |
src/Backend/Modules/MediaLibrary/Actions/MediaBrowser.php |
Uses compatible folder parsing. |
src/Backend/Modules/MediaGalleries/Actions/MediaGalleryEdit.php |
Updates message-bus lookup. |
src/Backend/Modules/MediaGalleries/Actions/MediaGalleryDelete.php |
Updates message-bus lookup. |
src/Backend/Modules/MediaGalleries/Actions/MediaGalleryAdd.php |
Updates message-bus lookup. |
src/Backend/Modules/Location/Ajax/UpdateMarker.php |
Uses compatible ID parsing. |
src/Backend/Modules/Location/Ajax/SaveLiveLocation.php |
Updates integer parsing. |
src/Backend/Modules/Location/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Locale/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Locale/Actions/Add.php |
Uses compatible ID parsing. |
src/Backend/Modules/Groups/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/FormBuilder/Resources/config/services.yml |
Adds service defaults. |
src/Backend/Modules/FormBuilder/Ajax/Sequence.php |
Uses compatible form ID parsing. |
src/Backend/Modules/FormBuilder/Ajax/SaveField.php |
Updates scalar parameter parsing. |
src/Backend/Modules/FormBuilder/Ajax/GetField.php |
Uses compatible ID parsing. |
src/Backend/Modules/FormBuilder/Ajax/DeleteField.php |
Uses compatible ID parsing. |
src/Backend/Modules/FormBuilder/Actions/MassDataAction.php |
Uses compatible form ID parsing. |
src/Backend/Modules/FormBuilder/Actions/ExportData.php |
Uses compatible ID parsing. |
src/Backend/Modules/FormBuilder/Actions/Edit.php |
Updates parameter and validator access. |
src/Backend/Modules/FormBuilder/Actions/DataDetails.php |
Uses compatible ID parsing. |
src/Backend/Modules/FormBuilder/Actions/Data.php |
Uses compatible ID parsing. |
src/Backend/Modules/FormBuilder/Actions/Add.php |
Updates validator lookup. |
src/Backend/Modules/Faq/Ajax/SequenceQuestions.php |
Updates integer parsing. |
src/Backend/Modules/Faq/Actions/EditCategory.php |
Uses compatible ID parsing. |
src/Backend/Modules/Faq/Actions/Edit.php |
Uses compatible ID parsing. |
src/Backend/Modules/Extensions/Actions/EditThemeTemplate.php |
Updates parsing and validation. |
src/Backend/Modules/Extensions/Actions/AddThemeTemplate.php |
Updates parsing and validation. |
src/Backend/Modules/ContentBlocks/Actions/Edit.php |
Updates services and parameters. |
src/Backend/Modules/ContentBlocks/Actions/Delete.php |
Updates message-bus lookup. |
src/Backend/Modules/ContentBlocks/Actions/Add.php |
Updates message-bus lookup. |
src/Backend/Modules/Blog/Tests/Actions/DeleteTest.php |
Updates nested request access. |
src/Backend/Modules/Blog/Actions/Index.php |
Uses compatible category parsing. |
src/Backend/Modules/Blog/Actions/EditComment.php |
Uses compatible ID parsing. |
src/Backend/Modules/Blog/Actions/EditCategory.php |
Uses compatible ID parsing. |
src/Backend/Modules/Blog/Actions/Edit.php |
Updates numeric parameter parsing. |
src/Backend/Modules/Blog/Actions/Add.php |
Uses compatible category parsing. |
src/Backend/Form/Type/EditorType.php |
Adjusts JavaScript registration call. |
src/Backend/Core/Tests/BackendWebTestCase.php |
Retrieves sessions from requests. |
src/Backend/Core/Js/ckfinder/skins/forkcms/skin.js |
Removes CKFinder skin integration. |
src/Backend/Core/Js/ckfinder/plugins/README.md |
Removes CKFinder plugin documentation. |
src/Backend/Core/Js/ckfinder/core/connector/php/connector.php |
Removes CKFinder connector entry point. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Security/Csrf/TokenValidatorInterface.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Response/JsonResponse.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/ResourceType/ResourceTypeFactory.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Request/Transformer/TransformerInterface.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Request/Transformer/JsonTransformer.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Plugin/PluginInterface.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/zh-cn.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/vi.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/tr.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/sv.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/sl.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/ru.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/pt-br.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/nn.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/nl.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/nb.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/ko.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/ja.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/it.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/id.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/hr.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/he.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/gu.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/fr.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/fi.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/fa.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/et.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/es.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/es-mx.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/eo.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/en.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/de.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/da.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/ca.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/locales/bg.json |
Removes CKFinder locale. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Filesystem/Folder/Folder.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Filesystem/File/EditedImage.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Filesystem/File/DeletedFile.php |
Removes bundled CKFinder code. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/UnauthorizedException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/MethodNotAllowedException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidUploadException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidResourceTypeException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidRequestException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidPluginException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidNameException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidExtensionException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidCsrfTokenException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidConfigException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/InvalidCommandException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/FolderNotFoundException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/FileNotFoundException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/CKFinderException.php |
Removes CKFinder base exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/AlreadyExistsException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Exception/AccessDeniedException.php |
Removes CKFinder exception. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/ResizeImageEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/RenameFolderEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/RenameFileEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/ProxyDownloadEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/MoveFileEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/FileUploadEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/EditFileEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/DownloadFileEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/DeleteFolderEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/DeleteFileEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/CreateFolderEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/CopyFileEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/BeforeCommandEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Event/AfterCommandEvent.php |
Removes CKFinder event. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Error.php |
Removes CKFinder error definitions. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/ContainerAwareInterface.php |
Removes CKFinder interface. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/RenameFolder.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/Operation.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/GetFolders.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/GetFileUrl.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/GetFiles.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/DeleteFolder.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Command/CreateFolder.php |
Removes CKFinder command. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Cache/Adapter/AdapterInterface.php |
Removes CKFinder cache interface. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Backend/Adapter/EmulateRenameDirectoryInterface.php |
Removes CKFinder adapter interface. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Backend/Adapter/Dropbox.php |
Removes CKFinder Dropbox adapter. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Backend/Adapter/Cache/Storage/Memory.php |
Removes CKFinder cache adapter. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Authentication/CallableAuthentication.php |
Removes CKFinder authentication. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Authentication/AuthenticationInterface.php |
Removes CKFinder interface. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Acl/User/SessionRoleContext.php |
Removes CKFinder role context. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Acl/User/RoleContextInterface.php |
Removes CKFinder interface. |
src/Backend/Core/Js/ckfinder/core/connector/php/CKSource/CKFinder/Acl/Permission.php |
Removes CKFinder permissions. |
src/Backend/Core/Js/ckfinder/config.js |
Removes CKFinder configuration. |
src/Backend/Core/Js/ckfinder/ckfinder.html |
Removes CKFinder browser page. |
src/Backend/Core/Js/backend.js |
Removes CKFinder upload URL. |
src/Backend/Core/Engine/Url.php |
Updates nested parameter access. |
src/Backend/Core/Engine/TwigTemplate.php |
Updates Twig and CSRF lookups. |
src/Backend/Core/Engine/Model.php |
Uses compatible offset parsing. |
src/Backend/Core/Engine/Form.php |
Stops loading CKFinder. |
src/Backend/Core/Engine/Base/AjaxAction.php |
Replaces removed response factory. |
src/Backend/Core/Engine/Base/Action.php |
Updates request and form handling. |
src/Backend/Core/Ajax/UpdateSequence.php |
Updates message-bus lookup. |
phpcs.xml.dist |
Removes obsolete CKFinder exclusion. |
package.json |
Removes obsolete CKFinder lint exclusion. |
index.php |
Replaces deprecated proxy mask. |
CLAUDE.md |
Updates linting documentation. |
app/Kernel.php |
Adds container return type. |
app/config/sitemap.yml |
Adds service defaults. |
app/config/form.yml |
Adds service defaults. |
app/config/doctrine.yml |
Adds service defaults. |
app/config/config.yml |
Adds defaults and public aliases. |
app/config/config_test.yml |
Updates sessions and test database setup. |
app/config/config_test_install.yml |
Updates installer test sessions. |
app/config/config_install.yml |
Adds installer service defaults. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jonasdekeukelaere
approved these changes
Oct 13, 2026
TODO: convert to use dependency injection instead
tijsverkoyen
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.