fix: apply idsFilter when retrieving a foreign table by id - #1123
Open
hsusul wants to merge 1 commit into
Open
Conversation
retrieve({ id }) built the filter but never passed it into FOREIGN_TABLES_SQL, so the first foreign table was returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
Why?
foreignTables.retrieve({ id })builtidsFilterbut never passed it toFOREIGN_TABLES_SQL. With more than one foreign table,GET /foreign-tables/:idreturneddata[0]instead of the requested OID.Fixes #1121.
How?
Forward
idsFilterintoFOREIGN_TABLES_SQL, matching views/tables/materialized views.Checklist