Skip to content

chore: drop updateObjectMetadata and its event - #1351

Merged
ferhatelmas merged 1 commit into
masterfrom
ferhat/update-object-metadata
Aug 31, 2026
Merged

chore: drop updateObjectMetadata and its event#1351
ferhatelmas merged 1 commit into
masterfrom
ferhat/update-object-metadata

Conversation

@ferhatelmas

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Chore

What is the current behavior?

Dead code and diverged/wrong due to versioning

What is the new behavior?

Dropped.

Additional context

Related to #1341

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
Copilot AI lite review requested due to automatic review settings August 31, 2026 12:45
@ferhatelmas
ferhatelmas requested a review from a team as a code owner August 31, 2026 12:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — a clean, self-contained removal of dead code. Reviewed the Database interface/pg.ts implementation removal, the ObjectStorage.updateObjectMetadata deletion and its event/import cleanup, the otel instrumentation list update, and the matching test removal; a repo-wide grep confirms no remaining references to updateObjectMetadata or ObjectUpdatedMetadata.

Extended reasoning...

Overview

The diff removes the updateObjectMetadata feature end-to-end: the Database interface method (adapter.ts), its Postgres implementation (pg.ts), the ObjectStorage.updateObjectMetadata wrapper and its now-unused imports (object.ts), the ObjectUpdatedMetadata event class file and its barrel export (events/index.ts, events/lifecycle/object-updated.ts), the otel instrumentation entry, and the corresponding test case. It is purely subtractive (81 deletions, 1 line changed for an import statement) with no new logic introduced.

Security risks

None. No auth, crypto, or permission logic is touched; this only removes an unused code path and its webhook event.

Level of scrutiny

Low. I verified via git diff on each file that the removals are paired correctly (interface + implementation + caller + event + test), and a repository-wide grep for updateObjectMetadata and ObjectUpdatedMetadata returned zero matches, confirming there are no dangling callers (e.g., in HTTP routes/controllers) left referencing the removed method or event.

Other factors

The PR description states this is dead/diverged code being dropped as a chore, which matches what the diff shows. The bug-hunting pass reported no findings, and my own independent grep corroborates there's nothing left referencing the removed symbols.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33393351947

Coverage increased (+0.1%) to 81.464%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13258
Covered Lines: 11238
Line Coverage: 84.76%
Relevant Branches: 7869
Covered Branches: 5973
Branch Coverage: 75.91%
Branches in Coverage %: Yes
Coverage Strength: 615.58 hits per line

💛 - Coveralls

@ferhatelmas
ferhatelmas merged commit 789f084 into master Aug 31, 2026
30 checks passed
@ferhatelmas
ferhatelmas deleted the ferhat/update-object-metadata branch August 31, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants