chore: drop updateObjectMetadata and its event - #1351
Conversation
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
There was a problem hiding this comment.
Looks good — a clean, self-contained removal of dead code. Reviewed the Database interface/pg.ts implementation removal, the ObjectStorage.updateObjectMetadata deletion and its event/import cleanup, the otel instrumentation list update, and the matching test removal; a repo-wide grep confirms no remaining references to updateObjectMetadata or ObjectUpdatedMetadata.
Extended reasoning...
Overview
The diff removes the updateObjectMetadata feature end-to-end: the Database interface method (adapter.ts), its Postgres implementation (pg.ts), the ObjectStorage.updateObjectMetadata wrapper and its now-unused imports (object.ts), the ObjectUpdatedMetadata event class file and its barrel export (events/index.ts, events/lifecycle/object-updated.ts), the otel instrumentation entry, and the corresponding test case. It is purely subtractive (81 deletions, 1 line changed for an import statement) with no new logic introduced.
Security risks
None. No auth, crypto, or permission logic is touched; this only removes an unused code path and its webhook event.
Level of scrutiny
Low. I verified via git diff on each file that the removals are paired correctly (interface + implementation + caller + event + test), and a repository-wide grep for updateObjectMetadata and ObjectUpdatedMetadata returned zero matches, confirming there are no dangling callers (e.g., in HTTP routes/controllers) left referencing the removed method or event.
Other factors
The PR description states this is dead/diverged code being dropped as a chore, which matches what the diff shows. The bug-hunting pass reported no findings, and my own independent grep corroborates there's nothing left referencing the removed symbols.
Coverage Report for CI Build 33393351947Coverage increased (+0.1%) to 81.464%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
What kind of change does this PR introduce?
Chore
What is the current behavior?
Dead code and diverged/wrong due to versioning
What is the new behavior?
Dropped.
Additional context
Related to #1341