Skip to content

fix: add COLLATE "C" to name in versioned-object indexes - #1352

Merged
TylerHillery merged 1 commit into
masterfrom
tyler/fix/index-collation
Aug 31, 2026
Merged

fix: add COLLATE "C" to name in versioned-object indexes#1352
TylerHillery merged 1 commit into
masterfrom
tyler/fix/index-collation

Conversation

@TylerHillery

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Fix to add COLLATE "C" to the new version indexes that were added in #1341

@coveralls

coveralls commented Aug 31, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 33446721995

Coverage decreased (-0.1%) to 81.365%

Details

  • Coverage decreased (-0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 19 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

19 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
src/internal/http/agent.ts 17 32.56%
src/http/routes/s3/index.ts 2 86.09%

Coverage Stats

Coverage Status
Relevant Lines: 13258
Covered Lines: 11219
Line Coverage: 84.62%
Relevant Branches: 7869
Covered Branches: 5971
Branch Coverage: 75.88%
Branches in Coverage %: Yes
Coverage Strength: 615.59 hits per line

💛 - Coveralls

@TylerHillery
TylerHillery marked this pull request as ready for review August 31, 2026 18:58
@TylerHillery
TylerHillery requested a review from a team as a code owner August 31, 2026 18:58
Copilot AI lite review requested due to automatic review settings August 31, 2026 18:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the versioned-object indexes introduced in #1341 with the repository’s established bytewise sorting/search behavior by applying COLLATE "C" to storage.objects.name in those indexes, ensuring consistent index semantics with existing name-based comparisons.

Changes:

  • Add COLLATE "C" to name in the (bucket_id, name, version) unique index.
  • Add COLLATE "C" to name in the “current version” unique index (archived_at IS NULL).
  • Add COLLATE "C" to name in the “null version” unique index (NOT is_versioned).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
migrations/tenant/0065-objects-key-version-index.sql Applies COLLATE "C" to name in the (bucket_id, name, version) unique index.
migrations/tenant/0066-objects-current-version-index.sql Applies COLLATE "C" to name in the “current version” unique index predicate.
migrations/tenant/0067-objects-null-version-index.sql Applies COLLATE "C" to name in the “null version” unique index predicate.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread migrations/tenant/0066-objects-current-version-index.sql
Comment thread migrations/tenant/0065-objects-key-version-index.sql
@TylerHillery
TylerHillery force-pushed the tyler/fix/index-collation branch from cb441bc to c18fdb7 Compare August 31, 2026 20:53
@TylerHillery
TylerHillery changed the base branch from master to tyler/fix/multigres-direct-connection August 31, 2026 20:53
Base automatically changed from tyler/fix/multigres-direct-connection to master August 31, 2026 22:32
@TylerHillery
TylerHillery force-pushed the tyler/fix/index-collation branch from c18fdb7 to 476012d Compare August 31, 2026 22:32
Comment thread migrations/tenant/0065-objects-key-version-index.sql
@TylerHillery
TylerHillery merged commit b666a2c into master Aug 31, 2026
28 of 29 checks passed
@TylerHillery
TylerHillery deleted the tyler/fix/index-collation branch August 31, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants