fix: add COLLATE "C" to name in versioned-object indexes - #1352
Merged
Conversation
Coverage Report for CI Build 33446721995Coverage decreased (-0.1%) to 81.365%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions19 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the versioned-object indexes introduced in #1341 with the repository’s established bytewise sorting/search behavior by applying COLLATE "C" to storage.objects.name in those indexes, ensuring consistent index semantics with existing name-based comparisons.
Changes:
- Add
COLLATE "C"tonamein the(bucket_id, name, version)unique index. - Add
COLLATE "C"tonamein the “current version” unique index (archived_at IS NULL). - Add
COLLATE "C"tonamein the “null version” unique index (NOT is_versioned).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| migrations/tenant/0065-objects-key-version-index.sql | Applies COLLATE "C" to name in the (bucket_id, name, version) unique index. |
| migrations/tenant/0066-objects-current-version-index.sql | Applies COLLATE "C" to name in the “current version” unique index predicate. |
| migrations/tenant/0067-objects-null-version-index.sql | Applies COLLATE "C" to name in the “null version” unique index predicate. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TylerHillery
force-pushed
the
tyler/fix/index-collation
branch
from
August 31, 2026 20:53
cb441bc to
c18fdb7
Compare
TylerHillery
changed the base branch from
master
to
tyler/fix/multigres-direct-connection
August 31, 2026 20:53
Base automatically changed from
tyler/fix/multigres-direct-connection
to
master
August 31, 2026 22:32
TylerHillery
force-pushed
the
tyler/fix/index-collation
branch
from
August 31, 2026 22:32
c18fdb7 to
476012d
Compare
itslenny
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix to add
COLLATE "C"to the new version indexes that were added in #1341