feat: drop bucketid_objname and add version list test coverage - #1353
feat: drop bucketid_objname and add version list test coverage#1353TylerHillery wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
f7c3141 to
6a22625
Compare
Coverage Report for CI Build 33559482155Warning No base build found for commit Coverage: 81.496%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
6a22625 to
f3648fc
Compare
f3648fc to
e4b2e9c
Compare
8f764a9 to
5e4bb18
Compare
There was a problem hiding this comment.
Pull request overview
This PR advances the version-aware object listing rollout by removing the legacy bucketid_objname index and adding extensive test coverage around versioned listing behavior (v1 and v2), including pagination edge cases and filter interactions.
Changes:
- Adds v1 list tests covering
noncurrentVersions/deleteMarkersfilters and multi-version pagination/batch-boundary behaviors. - Adds a comprehensive v2 versioning test suite covering filter matrices, ordering within keys, pagination correctness, delimiter behavior, and continuation-token constraints.
- Introduces DB migration
0069and registers it to drop thestorage.bucketid_objnameindex concurrently.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/object.test.ts | Adds v1 versioned listing tests for filters and pagination/batch-boundary behaviors. |
| src/test/object-list-v2.test.ts | Adds v2 versioning-focused integration tests and DB seeding helpers. |
| src/internal/database/migrations/types.ts | Registers the new migration identifier and version number. |
| migrations/tenant/0069-drop-bucketid-objname-index.sql | Drops the legacy index concurrently (non-transactional migration). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
b49d8d3 to
4a6020e
Compare
535a32d to
abc9035
Compare
abc9035 to
6ada077
Compare
6ada077 to
83476c7
Compare
What kind of change does this PR introduce?
Part of the two phase roll out in #1346 to drop the
bucketid_objnameand add tests