Skip to content

feat: drop bucketid_objname and add version list test coverage - #1353

Open
TylerHillery wants to merge 6 commits into
tyler/feat/object-versioning-wave-2from
tyler/feat/object-versioning-wave-2a
Open

feat: drop bucketid_objname and add version list test coverage#1353
TylerHillery wants to merge 6 commits into
tyler/feat/object-versioning-wave-2from
tyler/feat/object-versioning-wave-2a

Conversation

@TylerHillery

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Part of the two phase roll out in #1346 to drop the bucketid_objname and add tests

@blacksmith-sh

This comment has been minimized.

@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from f7c3141 to 6a22625 Compare August 31, 2026 18:34
@coveralls

coveralls commented Aug 31, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 33559482155

Warning

No base build found for commit 59b8d06 on tyler/feat/object-versioning-wave-2.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 81.496%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 13349
Covered Lines: 11323
Line Coverage: 84.82%
Relevant Branches: 8003
Covered Branches: 6078
Branch Coverage: 75.95%
Branches in Coverage %: Yes
Coverage Strength: 656.28 hits per line

💛 - Coveralls

@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from 6a22625 to f3648fc Compare August 31, 2026 19:09
@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from f3648fc to e4b2e9c Compare August 31, 2026 19:37
@TylerHillery
TylerHillery marked this pull request as ready for review August 31, 2026 19:52
@TylerHillery
TylerHillery requested a review from a team as a code owner August 31, 2026 19:52

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread src/test/object-list-v2.test.ts
@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from 8f764a9 to 5e4bb18 Compare August 31, 2026 20:54
Copilot AI lite review requested due to automatic review settings August 31, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR advances the version-aware object listing rollout by removing the legacy bucketid_objname index and adding extensive test coverage around versioned listing behavior (v1 and v2), including pagination edge cases and filter interactions.

Changes:

  • Adds v1 list tests covering noncurrentVersions/deleteMarkers filters and multi-version pagination/batch-boundary behaviors.
  • Adds a comprehensive v2 versioning test suite covering filter matrices, ordering within keys, pagination correctness, delimiter behavior, and continuation-token constraints.
  • Introduces DB migration 0069 and registers it to drop the storage.bucketid_objname index concurrently.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/test/object.test.ts Adds v1 versioned listing tests for filters and pagination/batch-boundary behaviors.
src/test/object-list-v2.test.ts Adds v2 versioning-focused integration tests and DB seeding helpers.
src/internal/database/migrations/types.ts Registers the new migration identifier and version number.
migrations/tenant/0069-drop-bucketid-objname-index.sql Drops the legacy index concurrently (non-transactional migration).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/test/object-list-v2.test.ts
@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from b49d8d3 to 4a6020e Compare August 31, 2026 22:33
@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch 2 times, most recently from 535a32d to abc9035 Compare September 1, 2026 15:27
@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from abc9035 to 6ada077 Compare September 1, 2026 19:39
@TylerHillery
TylerHillery force-pushed the tyler/feat/object-versioning-wave-2a branch from 6ada077 to 83476c7 Compare September 1, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants