Repository navigation
Support module aliasing FlyingFox and FlyingSocks together - #246
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 72 72
Lines 3777 3777
=======================================
Hits 3540 3540
Misses 237 237 ☔ View full report in Codecov by Harness. |
swhitty
approved these changes
Oct 3, 2026
Contributor
Author
|
Thanks, Simon! It looks like Luke has fixes posted for what's failing in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I try to use a Swift package module alias for both FlyingFox and FlyingSocks, it fails to compile because SwiftPM omits the FlyingSocks alias from FlyingFox's compiler command.
This PR proposes a change that declares the existing CSystemLinux target as a direct conditional dependency of FlyingFox so that SwiftPM propagates both aliases.
The target and Linux/Android condition are already used by FlyingSocks. FlyingFox also checks canImport(CSystemLinux) when selecting its default socket pool, so making this dependency explicit matches an existing source-level relationship.
Ultimately, this is a compatibility workaround for SwiftPM's graph propagation bug.
In terms of compatibility:
My use case here is bundling FlyingFox into a binary, closed source framework that will be linked into other apps at or post runtime — I am using Swift Package Manager's module aliasing feature to avoid namespace clashes if the user is already including FlyingFox in their app.