Repository navigation
Fix unpacking packs on Composer < 2.2.6 and keep empty sections in composer.json and composer.lock - #1129
Merged
Conversation
…mposer.json and composer.lock
nicolas-grekas
force-pushed
the
unpack-fixes
branch
from
October 29, 2026 16:12
7831eef to
a07d27b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes found while looking at #783 again. They all touch
Unpacker::updateLock(), one commit each.Unpacking a pack removed the empty
require-devsection of composer.json, even withcomposer update.unpack()already removes the packs from composer.json, so I removed the second removal.composer requireremoves the empty section too: that part of #783 is fixed in composer/composer#13178.Unpacking failed with a fatal error on Composer < 2.2.6, because
getDevMode()doesn't exist there.Updating composer.lock turned the empty
stability-flags,platformandplatform-devobjects into arrays, and the nextcomposer updateturned them back. Flex now keeps them as objects, like Composer'sLockerdoes.