Repository navigation
Fix recipes:update when add-lines targets a file that the recipe also copies - #1133
Merged
Merged
Conversation
nicolas-grekas
force-pushed
the
addlines-update
branch
from
October 29, 2026 17:23
e4eca12 to
eca26d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the next release. Updating the phpunit/phpunit recipe from 10.0 to 11.1 never changed
phpunit.dist.xml, because add-lines replaced what copy-from-recipe computed for this file with its current contents. add-lines now adds its lines on top of the contents computed by the other configurators, and uses the current file only when there are none.