Repository navigation
Conversation
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
accountOwnsAllInputsto compact account summaries. It is computed while inspecting inputs already available to the existing summarizer: true requires a nonempty input set and a known positive value plus an owned nonempty descriptor for every input. Unknown, zero-value and mixed-owner inputs produce explicit false.This lets consumers derive ordinary outgoing native transfer amounts from existing account totals and fees without requesting full transaction bodies per Activity row. Existing account amount aliases, direction, asset summaries and raw/full transaction responses remain unchanged. No added RPCs or database reads.
Validation
Added table-driven ownership, amount-alias preservation and JSON omission/true/false regressions. TypeScript interface compilation, OpenAPI structural checks and diff checks passed. Independent static producer/consumer review found no blocker.
Go unit, connectivity and narrow Syscoin integration wrappers were attempted but stopped at local preflight: Go/RocksDB configuration is unavailable. They did not execute. This fork currently exposes no equipped self-hosted runner or testnet deployment mapping, so Go execution and deployment are not claimed. Keep this PR unmerged until actual Go tests pass.