Repository navigation
Enable extended spending index for Syscoin - #31
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f44a33270e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "public_binding_template": ":{{.Ports.BlockbookPublic}}", | ||
| "explorer_url": "", | ||
| "additional_params": "-dbcache=4294967296 -dbmaxopenfiles=500000 -workers=16 -chunk=1000", | ||
| "additional_params": "-dbcache=4294967296 -dbmaxopenfiles=500000 -workers=16 -chunk=1000 -extendedindex", |
There was a problem hiding this comment.
When this package is deployed over any existing Syscoin database, the generated service immediately starts with -extendedindex, but db/rocksdb.go:2394-2395 rejects databases whose stored setting is false. The repository's standard deployment path (.github/workflows/deploy.yml:174-178 and contrib/scripts/deploy-blockbook-local.sh:89-92) installs the package and restarts the same database without performing the documented rebuild or directory swap, so deploying either changed config takes that Blockbook instance offline. The migration must be implemented or enforced in the deployment path before changing the default startup flag; documentation alone does not protect automated deployments.
Useful? React with 👍 / 👎.
Syscoin spending lookups currently fall back to scanning an output address's transaction history because the extended index is disabled. Enable
-extendedindexfor Syscoin mainnet and testnet so newly built indexes store the spending transaction metadata and serve these lookups directly.Existing Blockbook databases created without the flag must be rebuilt before starting with the new setting. The operators confirmed that these few instances are managed manually and can be resynchronized from scratch, so an automated migration guard is outside this change. The documented rollout retains the existing index for rollback, builds a new index, and verifies synchronization and spending lookups before switching traffic. Syscoin Core blockchain data does not need rebuilding.
Validation:
-extendedindexflag.git diff --checkpassed and the merge is conflict-free.