Repository navigation
Mark Syscoin adaptations in upstream code - #33
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac93198da4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Token contains info about tokens held by an address | ||
| type Token struct { | ||
| // SYSCOIN: Both standard fields include the emitted SPTAllocated value. |
There was a problem hiding this comment.
Preserve Go deprecation markers
Because this new sentence is directly adjacent to Deprecated:, both lines now form one paragraph beginning with SYSCOIN:. Go deprecation tooling only recognizes paragraphs that begin with Deprecated:, so Token.Type—and the identical addition on TokenTransfer.Type—will no longer be reported as deprecated to Go consumers. Add a blank // separator before Deprecated: or place the deprecation paragraph first.
Useful? React with 👍 / 👎.
Mark the Syscoin-specific adaptations retained or added during upstream sync #32 with
// SYSCOINcomments. The annotations cover indexed record decoding, filtered history and XPUB pagination, API type extensions, and their regression tests.This is a comment-only change: comparison against the base confirms all executable source, build directives, and struct tags are unchanged. Existing generated TypeScript remains unchanged.
Validation:
git diff --checkand Go formatting checks passed.