Skip to content

Mark Syscoin adaptations in upstream code - #33

Merged
sidhujag merged 1 commit into
masterfrom
codex/mark-syscoin-upstream-changes
Oct 20, 2026
Merged

sidhujag merged 1 commit into
masterfrom
codex/mark-syscoin-upstream-changes

Conversation

@sidhujag

@sidhujag sidhujag commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Mark the Syscoin-specific adaptations retained or added during upstream sync #32 with // SYSCOIN comments. The annotations cover indexed record decoding, filtered history and XPUB pagination, API type extensions, and their regression tests.

This is a comment-only change: comparison against the base confirms all executable source, build directives, and struct tags are unchanged. Existing generated TypeScript remains unchanged.

Validation:

  • Independent review found no marker-placement issues.
  • git diff --check and Go formatting checks passed.
  • All 22 targeted Go tests/subtests passed, including basic and extended output decoding, index connect/disconnect, asset filtering, summary pagination, schema generation, and scan exhaustion.
  • Both Syscoin mainnet and testnet HTTP connectivity checks passed; backend/node RPC was not exercised.
  • Hosted lint passed. Hosted unit tests remain queued, so local Docker results provide the executed test evidence.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T17:55:57.119014Z ac93198 PR opened
🔒 Security Review ✅ Completed 2026-10-20T17:55:25.141626Z ac93198 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sidhujag
sidhujag merged commit 4cea9ff into master Oct 20, 2026
1 of 2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac93198da4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/types.go

// Token contains info about tokens held by an address
type Token struct {
// SYSCOIN: Both standard fields include the emitted SPTAllocated value.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Go deprecation markers

Because this new sentence is directly adjacent to Deprecated:, both lines now form one paragraph beginning with SYSCOIN:. Go deprecation tooling only recognizes paragraphs that begin with Deprecated:, so Token.Type—and the identical addition on TokenTransfer.Type—will no longer be reported as deprecated to Go consumers. Add a blank // separator before Deprecated: or place the deprecation paragraph first.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant