Repository navigation
fix(arch/riscv64): prefer DBCN over the deprecated legacy SBI console - #402
Merged
Merged
Conversation
yydawx
force-pushed
the
fix/riscv64-sbi-console
branch
from
September 29, 2026 02:35
2c558b2 to
f596f28
Compare
liulog
self-requested a review
September 29, 2026 02:47
liulog
approved these changes
Sep 29, 2026
Contributor
|
LGTM! I think the current implementation is fine; it achieves the goal of compatibility. Since DBCN supports outputting more characters at once, future possibilities—such as routing hvisor's own logs through DBCN or exposing DBCN capabilities to Guest VMs—can be addressed in other PRs. |
Contributor
Author
|
Thanks! I would finish rustsbi issue first. I would like to write down some follow issues , we may discuss at tomorrow meeting or later! Thanks for your time again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #401
The riscv64 console only used the legacy SBI console extension (EID
0x01/0x02), so firmwares implementing just DBCN (e.g. RustSBI) stayed silent, banner included.Probe DBCN once on first use, prefer it, fall back to legacy. Guest-facing EID
0x01/0x02are unchanged and now share the same backend.Verified on QEMU
virt+ OpenSBI v1.8.