Repository navigation
feat(docs-kit): stamp app-shell version into the generated skill - #657
Merged
Merged
Conversation
docs:sync substitutes the core package version into SKILL.md's metadata.app-shell-version and a Version section that tells agents to compare it with the installed package. The manifest hashes the unstamped content, so a changesets version bump doesn't register as skill drift; changeset:publish already re-syncs after the bump, so the tarball carries the released version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
/review |
Contributor
|
🚀 Code Review has started processing this issue comment |
Contributor
Code Metrics Report
Details | | main (b8ead52) | #657 (2cc681e) | +/- |
|---------------------|----------------|----------------|-------|
| Coverage | 89.5% | 89.5% | 0.0% |
| Files | 236 | 236 | 0 |
| Lines | 7517 | 7517 | 0 |
| Covered | 6732 | 6732 | 0 |
+ | Test Execution Time | 3m20s | 2m13s | -1m7s |Reported by octocov |
… be filled
- stampSkill throws instead of shipping a literal {{APP_SHELL_VERSION}}
- docs:check validates the stamp, since the manifest hashes unstamped content
- sync resolves the version before deleting the skill dir
- Version section resolves the installed package from the app, not the repo root
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
interacsean
marked this pull request as ready for review
October 29, 2026 05:03
IzumiSy
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes tailor-inc/platform-planning#2227
Summary
docs:syncwrites the core package version into the generatedapp-shell-patternsSKILL.md, both asmetadata.app-shell-versionin the frontmatter and in a new Version section. That section tells the agent to compare the stamp with the installed@tailor-platform/app-shelland to suggest re-syncing if the copy is out of date.docs-manifest.jsonhashes the unstamped content, so a changesets version bump never shows up as skill drift indocs:check.changeset:publishalready runsdocs:syncafter the version bump, so the published tarball carries the released version.outputs.skill.versionSource(packages/core/package.json).@tailor-platform/app-shell.Verification
testpasses 25/25, including the newskill.test.ts.type-check,lint,fmtanddocs:checkare all green.docs:checkstayed green and the re-synced skill showed 9.9.9.pnpm pack, the tarball'sskills/app-shell-patterns/SKILL.mdcontainsapp-shell-version: "1.18.0".🤖 Generated with Claude Code