Repository navigation
Conversation
Contributor
Code Metrics Report
Details | | main (b8ead52) | #659 (8e49999) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 89.5% | 89.7% | +0.2% |
| Files | 236 | 237 | +1 |
| Lines | 7517 | 7616 | +99 |
+ | Covered | 6732 | 6837 | +105 |
+ | Test Execution Time | 3m20s | 2m15s | -1m5s |Code coverage of files in pull request scope (82.2% → 93.0%, patch 99.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Navigation labels sometimes need more room, but the sidebar currently supports only expanding and collapsing. Make resizing a standard desktop interaction, including reopening a collapsed sidebar and continuing to resize without releasing the pointer.
Design Decision
Default-enabled desktop behavior
Resizing is enabled by default in
<SidebarLayout />and<GlobalHeaderLayout />; apps can opt out withresizable={false}. Mobile/tablet behavior remains unchanged. Only the central grip starts resizing, and the grip remains available when collapsed. Pointer gestures use position-based resistance and early collapse snapping rather than delayed mouse tracking or a jump to the default width. Click and keyboard expansion still restore 256px.Live pixels outside React state
Keep pointer capture and interaction decisions in JavaScript, but apply live width and position through CSS custom properties with
calc()andmax(). React commits widths only at mode changes and gesture completion, avoiding per-move rerenders and Context updates while keeping ARIA values current. Content continues resizing live, so layout work remains; this is not a compositor-only animation.Summary