Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Code Metrics Report
Details | | main (9f68121) | #661 (0a94472) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 89.5% | 89.5% | 0.0% |
| Files | 236 | 236 | 0 |
| Lines | 7517 | 7517 | 0 |
| Covered | 6732 | 6732 | 0 |
- | Test Execution Time | 2m56s | 3m25s | +29s |Reported by octocov |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of tailor-inc/platform-planning#2208. #641 listed one open item: in light mode,
textonsurface-hoveris below 4.5:1 fordanger(4.22:1) andsuccess(4.34:1 over--background). It said that choosing another step was a visible change for a later PR. This PR records the decision instead.Decision
Keep
surfaceat a3 andsurface-hoverat a4. I compared three ways to reach 4.5:1:surfacea2,surface-hovera3surfacevs--card: 1.16:1 with a3, 1.06:1 with a2. The hover step also gets smaller: 1.16:1 with a3→a4, 1.10:1 with a2→a3.warningdoes)text-danger-textandtext-success-textchanges from red or green to a dark brown or dark green.The hover state is short, and the text stays above 4.2:1. This does not meet WCAG 1.4.3 for the hover state, so it stays in the styling guide's list of exceptions, and the test keeps the 4.2:1 floor.
Changes
decisions/semantic-color-roles.md: new section "Update 2026-10-30: the hover step stays", with the comparison and the reasons.Checks
docs:checkandfmt:checkpass.main(light mode), composited over--cardand--background.🤖 Generated with Claude Code