Repository navigation
Add revise-planning.sh with a recorded decision per finding - #50
Merged
Merged
Conversation
revise-planning.sh lets the project planner handle a current planning review in two phases: read-only, it decides ADOPT, REJECT, DEFER, or ESCALATE per finding with a rationale, validated like review results; after approval, the decisions are recorded and a write session resolves exactly the adopted findings, limited to the architecture, roadmap, and ADRs. Critical and major findings may only be adopted or escalated. Scope snapshots move from start-planning.sh into scripts/lib/scope.sh, and the read-only runner accepts a validator for other result types. Closes #46 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The review-planning test committed in a cloned repository without a Git identity, which passed locally through the global configuration and failed on CI. The clone now sets its identity, and every test suite runs with GIT_CONFIG_GLOBAL=/dev/null and GIT_CONFIG_NOSYSTEM=1, as on CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
./scripts/revise-planning.sh --review <planning-review-json>, run in the planning worktree with roleproject-planner, in two phases mirroring triage and apply-triage:ADOPT,REJECT,DEFER, orESCALATE, with a rationale. Validated with the shared library; Critical and Major may only be adopted or escalated; invalid results are retried once. Shown to the human and recorded only after approval as<review>-revision.jsonwith a generated report.docs/architecture.md,docs/roadmap.md, and direct Markdown ADRs may change; any other change (requirements, description, review artifacts, ignored files), a commit, or no change at all fails the run and preserves the worktree..agents/prompts/planning-reviser.mdand schema.agents/schemas/revision.schema.json.start-planning.shintoscripts/lib/scope.sh(its test suite still passes). The read-only runner inscripts/lib/review-run.shtakes a validator.review-planning.shandtriage-review.shnow point torevise-planning.sh.docs/development.mddescribes the review ↔ revision loop.Issue / acceptance criteria
Closes #46
Risk
Verification evidence
./scripts/verify.shpassed (13 checks)tests/revise-planning-test.sh, also passing under macOS system bash 3.2)Tested with fake agents only; not yet run against a real planner session.
Independent review: Codex (
gpt-6-astra), read-only. CHANGES REQUIRED:Not re-reviewed after the fixes.
Agent involvement
Planner: —
Implementer: Claude (Opus 5.5)
Reviewer: Codex (gpt-6-astra)
Production impact
None.
🤖 Generated with Claude Code