Add finish-planning.sh with an approval tied to the planning documents - #51
Merged
Merged
Conversation
finish-planning.sh checks that the requirements are approved, the latest planning review is current, and its round is resolved: no critical or major finding, a decision for every finding, nothing adopted but not applied, and no escalation. Earlier escalations need an explicit resolution. It shows every finding that was not adopted and records the approval in docs/PLANNING_APPROVAL.md with the reviewed fingerprint of the planning documents. finish-planning.sh --check reports whether the approval still matches the documents, and create-feature-issue.sh requires a current approval. The planning scope is shared in scripts/lib/planning.sh. Closes #47 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
./scripts/finish-planning.shin the planning worktree. It refuses when a required document is missing, the requirements are not approved, there is no planning review, the latest review is stale, its round has a critical or major finding, a finding has no revision decision, an adopted finding is not applied yet, or a finding of the latest round is escalated.docs/PLANNING_APPROVAL.md(committed): time, branch, final round, all review rounds, confirmed escalations, findings not adopted, and the fingerprint of the reviewed planning. A document that changes while the script waits for the answer is refused../scripts/finish-planning.sh --checkexits 0 when the approval matches the documents, 1 when it is missing or stale.create-feature-issue.sh <feature-id>refuses to create a feature Issue without a current planning approval.scripts/lib/planning.sh, shared byreview-planning.sh,finish-planning.sh, andcreate-feature-issue.sh.docs/development.md, anddocs/agentic-workflow.mddescribe description → planning → review ↔ revision → approval → feature Issues.Issue / acceptance criteria
Closes #47
Risk
Verification evidence
./scripts/verify.shpassed (14 checks), also without global or system Git configurationtests/finish-planning-test.sh, also passing under macOS system bash 3.2)Independent review: Codex (
gpt-6-astra), read-only. CHANGES REQUIRED:Not re-reviewed after the fixes.
Agent involvement
Planner: —
Implementer: Claude (Opus 5.5)
Reviewer: Codex (gpt-6-astra)
Production impact
None.
🤖 Generated with Claude Code