Redesign finish-feature.sh as the closing step of a feature

[taspinar]

What changed

• ./scripts/finish-feature.sh <issue> "<summary>" [--no-review "<reason>"] replaces the broken script and supersedes Add commit-feature.sh helper script #6 and Deprecate or redesign finish-feature.sh for the pre-commit review workflow #9. In the feature worktree it:
  • refuses another branch than feature/<issue>-* and a tree without changes;
  • runs ./scripts/verify.sh;
  • requires the latest review of the feature to be current and free of critical and major findings;
  • requires every review round with findings to have an approved triage (the newest by number) that was published on the Issue, and the latest round to have no FIX_NOW findings left; a passed newer round confirms earlier fixes;
  • stages all changes (review and triage files are ignored) and opens a structured commit message in the editor: summary, Issue, changes to fill in, verification, review round and verdict, Refs #<issue>. An emptied message aborts the commit.
• --no-review "<reason>" finishes a low-risk change without a review and records the reason in the commit message.
• It never pushes, opens a PR, or merges; it prints those next steps.
• triage-review.sh records published_at in the triage after publication, and triage-review.sh --publish <triage-json> [--mark-only] repeats a failed publication.
• README, docs/development.md, and docs/agentic-workflow.md end the feature workflow with finish-feature.sh.

Issue / acceptance criteria

Closes #48

Risk

• Low
• Medium
• High

Verification evidence

• ./scripts/verify.sh passed (15 checks), also without global or system Git configuration
• Tests added/updated where appropriate (tests/finish-feature-test.sh, also passing under macOS system bash 3.2)
• Independent review completed when required
• Architecture/docs/ADR updated when required

Independent review: Codex (gpt-6-astra), read-only. CHANGES REQUIRED:

• M1 (a passed second round bypassed a missing or unpublished triage of round 1): fixed; every round with findings is checked. Tested with two rounds.
• M2 (the first, unnumbered triage could be chosen over a newer numbered one): fixed by selecting triages by number. Tested.

Not re-reviewed after the fixes.

Agent involvement

Planner: —
Implementer: Claude (Opus 5.5)
Reviewer: Codex (gpt-6-astra)

Production impact

None.

🤖 Generated with Claude Code