fix(deps): bump brace-expansion and js-yaml to resolve 6 Dependabot alerts - #51
Merged
Merged
Conversation
Six Dependabot alerts are open against transitive devDependencies, all denial-of-service advisories reachable through eslint and jest tooling: - brace-expansion GHSA-3jxr-9vmj-r5cp (alerts #62, #59) - js-yaml GHSA-52cp-r559-cp3m (alerts #61, #60) - js-yaml GHSA-h67p-54hq-rp68 (alerts #58, #57) Each package appears twice in the tree at different majors, so a single bump would have left half the alerts open. Plain `npm audit fix` covers all six within the existing package.json semver ranges, which is why this touches package-lock.json only: - brace-expansion 1.1.12 -> 1.1.16, 5.0.6 -> 5.0.8 - js-yaml 3.14.2 -> 3.15.0, 4.1.1 -> 4.3.0 `--force` was deliberately avoided: the only remaining advisory (brace-expansion GHSA-mh99-v99m-4gvg) would require eslint@10, and GitHub has already auto-dismissed that alert. Trading a breaking lint upgrade for a dev-only DoS fix is not worth it in a TDD workshop skeleton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm audit fixの結果、package-lock.jsonのみの変更です。解消される Dependabot アラート (6件すべて)
< 1.1.16>= 3.0.0, < 5.0.7>= 4.0.0, < 4.3.0>= 3.0.0, < 3.15.0< 3.15.0>= 4.0.0, <= 4.1.1いずれも devDependencies の推移的依存で、DoS 系の advisory です。
brace-expansionとjs-yamlはそれぞれ依存ツリー内に異なるメジャーで2箇所存在するため、片方だけの更新では半分のアラートが残ります。--forceを使っていない理由package.jsonの semver 範囲内でオープンな6件すべてが解消できるため、lockfile のみの変更で済んでいます。残る
brace-expansionGHSA-mh99-v99m-4gvg (alert #63) はnpm audit fix --force=eslint@10への破壊的アップグレードが必要ですが、このアラートは GitHub 側で既にauto_dismissedになっているため対象外としました。動作確認
ローカル (Node v24.18.0 / npm 11.16.0) で以下を確認済みです。
npm test(pretest のprettier --check+eslintを含む) → 2 passednpm run test:mjs→ 2 passednpm ciでクリーンインストールが再現し、lockfile が追加変更されないことintegrityハッシュが npm レジストリの実体と一致することbrace-expansion5.0.8 はenginesから Node 18 が外れますが (18 || 20 || >=22→20 || >=22)、CI マトリクスは Node 22.x / 24.x のため影響ありません。