Repository navigation
feat: 원판 계산기 서버 API 연동 - #183
Merged
Merged
Conversation
dltldn1234
approved these changes
Nov 4, 2026
dltldn1234
left a comment
Member
There was a problem hiding this comment.
요청 경로와 POST 메서드, 요청/응답 필드가 #182 및 API 계약 매핑과 일치하는 것을 확인했습니다. Debug 빌드에서만 localhost 서비스가 주입되고 Release에는 네트워크 구성이 추가되지 않았으며, 기존 네트워크 서비스 테스트도 요청 경로와 응답 디코딩을 확인합니다. CI의 Generate/Lint/Test 체크도 통과했습니다. 승인합니다. 참고로 이 PR에서 새 ViewModel 전용 회귀 테스트와 성공 응답의 실제 Compose 서버 왕복은 확인되지 않았습니다. 서버가 준비되면 성공 응답이 화면에 반영되는 흐름도 수동 검증해 주세요.
A6ul1213
marked this pull request as ready for review
November 4, 2026 07:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/tools/plate-calculator를 원판 계산 화면의 ViewModel에 연결했습니다.http://localhost:8000)를 사용하고, Release에는 서버 연결을 추가하지 않았습니다.Related issue
Closes #182
Verification
Review checklist