Skip to content

Reduce the test to discounts, and ask for a command line caller - #453

Open
Miljar wants to merge 2 commits into
masterfrom
discounts-console-command
Open

Miljar wants to merge 2 commits into
masterfrom
discounts-console-command

Conversation

@Miljar

@Miljar Miljar commented Sep 18, 2026

Copy link
Copy Markdown

Two changes to the candidate-facing test.

Only the discounts problem remains

The ordering SPA and the local development problem are no longer sent out, so this removes
2-ordering.md, 3-local-development.md, and the problem-3/ example project that only the
latter referenced. .github/dependabot.yml went with them, since it existed solely to watch
problem-3/client for npm updates. That also clears the 55 dependabot alerts currently open
against master, all of which came from problem-3/client/package-lock.json.

data/ and example-orders/ stay. The discounts problem uses both.

The test now asks for two callers

1-discounts.md previously described a single HTTP door. It now also asks for a command line
caller that prices a set of orders and reports what each one gets.

Both doors are described neutrally, with no guidance on how to build either. How a candidate
gets there, including whether they reach for a framework, is left open and asked about in the
interview instead.

Nothing else in the problem changed. Same three rules, same fixtures, same guidelines.

Reviewer note: keep this description and the commit messages free of what the added caller is
meant to reveal. The repo is public and candidates read it. That reasoning belongs in the
interviewer guide.

The ordering SPA and the local development problem are no longer sent to
candidates, so remove them along with the example project that only
problem 3 referenced. The dependabot config existed solely to watch
problem-3/client, so it goes too.
@Miljar
Miljar requested a review from a team as a code owner September 18, 2026 12:03
@Miljar
Miljar force-pushed the discounts-console-command branch from 526be0d to 4c3d2a0 Compare September 18, 2026 12:13
Candidates now build two ways of calling the discount service instead of
one. The command prices a set of orders and reports what each one gets.
@Miljar
Miljar force-pushed the discounts-console-command branch from 4c3d2a0 to b1f67c1 Compare September 18, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants