Repository navigation
fix(sdk-bedrock): report a failure in stream chunk timing and the first-chunk update - #190
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bedrock stream wrappers dropped a failure while they recorded an output-chunk timestamp or the time to first chunk, in TypeScript and Python. The span lost that timing, and nothing reached
onError. Both failures now go through the stream's existing reporter, as google-genai and litellm already do. They still don't settelemetry.dev.capture.truncated, cut the output, or raise into the caller's loop.The reporter keeps one report per stream, so a timing failure that comes first hides a later mapping failure's report. The flag from that later failure is still set. Both READMEs now say this. TypeScript's
updateSpanhad only this one caller, so it's removed and the update is guarded inline.Fixes #189
Tests run:
vp test runinpackages/bedrock(90 passed) andvp check, and insdks/python-bedrockruff, pyright,pytest(108 passed) and.github/scripts/python_dependency_bounds.sh. The new rows in each language's stream mapping-failure table fail when their report is removed.