Repository navigation
refactor(sdk): call span handle members directly in the python integrations - #198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bedrock, google-genai, litellm and openrouter integrations now call
SpanHandle.capture_masked,SpanHandle.record_output_chunkandSpanHandle.capture_outputdirectly, and bedrock readsClient.maskdirectly, the way anthropic and openai already do. Thegetattrfallbacks they replace were written for cores without these members, but every integration requirestelemetry-dev>=0.3.0, and the published 0.3.0 wheel has all four. This settles the Python compatibility item in #83.Behavior doesn't change. With 0.3.0 from PyPI, a handle from a disabled client reports
capture_maskedandcapture_outputas false and acceptsrecord_output_chunk. A handle from a client with a mask reportscapture_maskedas true. The fallbacks forCaptureBudget.for_stream,CaptureBudget.reserve_bytesandprompt_attributes_forstay, because 0.3.0 doesn't have those.Refs #83