Skip to content

Use eigh in bath op assertion #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gefux merged 2 commits into from
Aug 8, 2026
Merged

Use eigh in bath op assertion #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
434b047
Use eigh in bath op assertion
piperfw Aug 3, 2026
4b5eb02
Add bath test for degenerate coupling operator
gefux Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oqupy/bath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def __init__(
self._coupling_operator = tmp_coupling_operator
self._unitary = np.identity(self._dimension)
else:
w, v = np.linalg.eig(tmp_coupling_operator)
w, v = np.linalg.eigh(tmp_coupling_operator)
self._coupling_operator = np.diag(w)
self._unitary = v
assert np.allclose(tmp_coupling_operator, \
Expand Down
21 changes: 20 additions & 1 deletion tests/coverage/bath_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

from oqupy.bath import Bath
from oqupy.bath_correlations import PowerLawSD
from oqupy import operators

def test_bath():
wc = 4.0
Expand Down Expand Up @@ -79,6 +78,26 @@ def test_bath():
assert np.array_equal(bath_C.west_degeneracy_map,[0,0,0,0])
assert np.array_equal(bath_C.north_degeneracy_map,[0,0,0,0])

# Checks that the diagonalisation of the bath also works for degenerate
# coupling operators (see issue #165)
def test_bath_degenerate_coupling_op():
degenerat_coupling_op = np.array(
[[0.+0.j, 1.+0.j, 1.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j],
[1.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j],
[1.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j],
[0.+0.j, 1.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j],
[1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 1.+0.j, 0.+0.j],
[0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 1.+0.j],
[0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 1.+0.j],
[0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 1.+0.j, 1.+0.j, 0.+0.j]])
correlations = PowerLawSD(
alpha=0.02,
zeta=1,
cutoff=0.5,
cutoff_type="exponential",
temperature=0.5)
Bath(degenerat_coupling_op, correlations) # this failed before PR #166

def test_bath_bad_input():
wc = 4.0
alpha = 0.3
Expand Down
Loading