Drop reset_attempts and reset_heartbeat from UnpauseActivityExecution - #846
Open
dandavison wants to merge 3 commits into
Open
Drop reset_attempts and reset_heartbeat from UnpauseActivityExecution#846dandavison wants to merge 3 commits into
reset_attempts and reset_heartbeat from UnpauseActivityExecution#846dandavison wants to merge 3 commits into
Conversation
Unpause resumes an activity; it should not also mutate the attempt counter or discard the heartbeat checkpoint. Neither selective form has demonstrated user demand, and an operator who wants either would look for it on Reset. Ship the simple API first. The field numbers and names are reserved. The deprecated UnpauseActivity, the batch operations, and the Reset APIs are untouched. make proto
Drops reset_attempts and reset_heartbeat from the deprecated UnpauseActivity and from BatchOperationUnpauseActivities, so unpause means the same thing on every surface. Numbers and names reserved. The Reset APIs keep their flags: Reset is the operation that restarts an activity as if on its first attempt. make proto
This reverts commit 1cc925e.
dandavison
requested review from
a team,
GregoryTravis,
fretz12,
maciejdudko and
spkane31
August 1, 2026 23:28
Draft
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
reset_attemptsandreset_heartbeatfromUnpauseActivityExecutionWhy?
UnpauseandResetfunctionality in a confusing wayA commit for extending this to WFA is reverted in history; we can do this later.
Breaking changes
reset_attemptsandreset_heartbeatoptions ofUnpauseActivityExecutionwill no longer see their effects.