Skip to content

Document the single-argument Workflow input recommendation - #5450

Merged
Duncanma merged 2 commits into
mainfrom
duncan/workflow-single-argument-edbf1d
Oct 7, 2026
Merged

Duncanma merged 2 commits into
mainfrom
duncan/workflow-single-argument-edbf1d

Conversation

@Duncanma

@Duncanma Duncanma commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

What

Most SDK pages already recommend a single object parameter for Workflows, but the guidance was inconsistent and nowhere explained why.

  • Add a Workflow parameters section to the Workflow Definition page. It recommends one object parameter and gives three reasons: you can add fields without changing the signature, the type-safe start forms only accept a single argument, and the Web UI sends one argument.
  • Say "single" in the TypeScript, .NET, and Ruby Workflow parameter guidance, which only said "objects" before. Add a Define Workflow parameters heading to .NET and Ruby, and link all three to the new section.
  • Link the Web UI single-argument note (Document that the Web UI passes input as a single argument #5439) to the general recommendation.

Notes for review

  • The "type-safe forms only accept a single argument" claim comes from a Slack thread cited in a Kapa answer. I worded it as "in several SDKs"; worth checking against the SDKs.
  • Go, Python, Java, PHP, and Rust already recommend a single object, so they are unchanged.
  • No new best-practices page. It would duplicate the new section.

Checks

  • vale --config .vale-ci.ini is clean on the touched files.
  • I did not run yarn build or yarn check-links locally.

Add a Workflow parameters section to the Workflow Definition page with the
reasons to use one object parameter. Say 'single' in the TypeScript, .NET,
and Ruby Workflow parameter guidance, and link the Web UI note to it.
@Duncanma
Duncanma requested a review from a team as a code owner October 7, 2026 22:44
Copilot AI balanced review requested due to automatic review settings October 7, 2026 22:44
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
temporal-documentation Ready Ready Preview Oct 7, 2026 10:50pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing Go, Python, Java, PHP, and Rust guidance still needs links to the new canonical rationale.

1 open finding
What changed in this PR

Adds centralized guidance recommending a single object parameter for Workflows and links SDK and Web UI documentation to it.

Changes:

  • Explains the compatibility, type-safety, and Web UI benefits.
  • Clarifies TypeScript, .NET, and Ruby recommendations.
  • Connects Web UI guidance to the canonical section.
File Description
docs/​web-ui.mdx Links Web UI input guidance to the recommendation.
docs/​encyclopedia/​workflow/​workflow-definition.mdx Adds the canonical Workflow parameters guidance.
docs/​develop/​typescript/​workflows/​basics.mdx Recommends one object parameter.
docs/​develop/​ruby/​workflows/​basics.mdx Recommends one hash or object parameter.
docs/​develop/​dotnet/​workflows/​basics.mdx Recommends one class parameter.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/encyclopedia/workflow/workflow-definition.mdx
@Duncanma
Duncanma enabled auto-merge (squash) October 7, 2026 22:48

@lennessyy lennessyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "For more reasons", maybe just say "for more details?" I feel like "for more reasons" sounds slightly awkward

@Duncanma
Duncanma merged commit c0cf57d into main Oct 7, 2026
18 checks passed
@Duncanma
Duncanma deleted the duncan/workflow-single-argument-edbf1d branch October 7, 2026 22:51

This branch was successfully deployed

1 active deployment
Preview — 72b05840 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants