Skip to content

Replace credentials.enabled with credentials.identity - #310

Merged
hehaifengcn merged 2 commits into
mainfrom
haifengh/credentials-identity
Oct 8, 2026
Merged

hehaifengcn merged 2 commits into
mainfrom
haifengh/credentials-identity

Conversation

@hehaifengcn

@hehaifengcn hehaifengcn commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Add local.credentials.identity to control credentials sent to the local Temporal server

local.credentials.identity sets whose credentials (authorization / authorization-extras) the local Temporal server sees on calls from the proxy:

identity Caller's credentials Proxy's CredentialProvider credentials
default (unset) forwarded not sent
proxy stripped sent
strip stripped not sent
local:
  credentials:
    identity: proxy

local.credentials.identity controls whose credentials the local Temporal
server sees, in the "authorization" and "authorization-extras" headers:

  caller (default)  forward whatever the caller sent; add nothing
  proxy             drop forwarded credentials and send the
                    CredentialProvider's instead
  none              drop forwarded credentials and send none

With identity "proxy", a replication stream forwarded from the remote side
reaches the local server with only the proxy's token, never with a token
the remote side sent. Forwarded credentials are removed by a client
interceptor that runs before gRPC adds the per-RPC credentials, so the
proxy's own token is never stripped.

Validation rejects unknown identities, identity "proxy" on a non-TCP local
connection, and any remote.credentials block. The proxy refuses to start
with identity "proxy" and no CredentialProvider.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hehaifengcn
hehaifengcn requested a review from a team as a code owner October 8, 2026 16:28
Rename CredentialIdentityCaller to CredentialIdentityDefault ("default"),
which forwards the caller's credentials and applies when identity is not
set, and CredentialIdentityNone to CredentialIdentityStrip ("strip").
Rename auth.ForwardedCredentialHeaders to auth.CredentialHeaders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hehaifengcn
hehaifengcn merged commit da11f1a into main Oct 8, 2026
6 checks passed
@hehaifengcn
hehaifengcn deleted the haifengh/credentials-identity branch October 8, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants