Repository navigation
Fix Cloud Run sample: canonical collector names, deploy command, service account - #558
Merged
Merged
Conversation
yuandrew
approved these changes
Oct 6, 2026
seanbollin
force-pushed
the
fix-cloud-run-collector-config
branch
from
October 6, 2026 22:39
6e3c340 to
5b405ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found via an end-to-end Cloud Run deploy test:
otelcol-googlecomponent names — rename theresourcedetectionprocessor toresource_detection(the deprecated alias logs runtime warnings). The receiver staysotlpand the exporter staysotlp_grpc; those are already the canonical names for this distribution (there is nootlp_grpcreceiver, and no plainotlpexporter). Verified withotelcol-google:0.156.0 validate(exit 0).--regionflag fromgcloud beta run worker-pools replace(region comes from thecloud.googleapis.com/locationlabel in the YAML).serviceAccountName: <SERVICE_ACCOUNT>, and document in the README that it needsroles/monitoring.metricWriter,roles/telemetry.tracesWriter, androles/secretmanager.secretAccessor.!from the workflow input so the result isHello, Cloud Run Worker!(wasHello, Cloud Run Worker!!), matching the README.